Closed Bug 1569180 Opened 5 years ago Closed 5 years ago

URL Dropdown Menu renders underneath bookmark toolbar

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Version:
70 Branch
Platform:
Desktop
All
Type:
defect
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 70
Iteration:
70.2 - Jul 22 - Aug 4
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 + verified

People

(Reporter: eira.lindblad, Assigned: dao)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(2 files)

Example
19.53 KB, image/png
Details
Bug 1569180 - Set z-index on urlbar-results so it renders over the bookmkars toolbar. r=mak
47 bytes, text/x-phabricator-request
Details | Review
Attached image Example —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

I typed in the address bar so that the suggestions dropdown menu showed up

Actual results:

The dropdown menu rendered behind the text of the bookmarks in bookmark toolbar.

Expected results:

The dropdown menu should have rendered above the bookmark text, and indeed any other browser element.

According to https://twitter.com/ValkyrieEira/status/1154745226780717057 this is with today's build 2017-07-26 (not available yet for my linux version in French so I don't know if the bug is platform specific yet). Bug 1551598 landed this morning and looks like a potential regressor.

Status: UNCONFIRMED → NEW
status-firefox68: --- → unaffected
status-firefox69: --- → unaffected
status-firefox70: --- → affected
status-firefox-esr60: --- → unaffected
status-firefox-esr68: --- → unaffected
tracking-firefox70: --- → +
Ever confirmed: true
Keywords: nightly-community, regression, regressionwindow-wanted
See Also: → 1551598

I am seeing it on Linux as well, setting Platform to All.

5:35.88 INFO: Last good revision: 47e72c204ef61c34509e430c0976f4db680e384a
5:35.88 INFO: First bad revision: 580d975db59096011e93150a04856a15b9e8812d
5:35.88 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=47e72c204ef61c34509e430c0976f4db680e384a&tochange=580d975db59096011e93150a04856a15b9e8812d

Dao, it seems that your patch in Bug 1551598 caused this regression, could you have a look please? Thanks

Component: Untriaged → Address Bar
Flags: needinfo?(dao+bmo)
Keywords: regressionwindow-wanted
OS: Unspecified → All
Regressed by: 1551598
Hardware: Unspecified → Desktop
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 70.2 - Jul 22 - Aug 4
Points: --- → 2
Flags: needinfo?(dao+bmo)
Priority: -- → P1
See Also: 1551598 →
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5caaa674b95 Set z-index on urlbar-results so it renders over the bookmkars toolbar. r=mak

https://hg.mozilla.org/mozilla-central/rev/f5caaa674b95

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Blocks: urlbar-update-1

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 70.0a1 (2019-07-27), so I'm marking this bug as VERIFIED.
Thank you very much! \o/

Status: RESOLVED → VERIFIED
status-firefox70: fixed → verified
QA Contact: Virtual
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: