Closed Bug 1569253 Opened 1 year ago Closed 3 months ago

Remove old password manager UI (passwordManager.xhtml) from mozilla-central

Categories

(Toolkit :: Password Manager, task, P1)

Desktop
All
task

Tracking

()

VERIFIED FIXED
mozilla77
Tracking Status
firefox70 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- verified

People

(Reporter: MattN, Assigned: severin)

References

Details

(Whiteboard: [passwords:management])

Attachments

(1 file)

Some time after a successful release of about:logins we should remove the old password management UI that we will no longer maintain in m-c. In bug 1569113 it will be ported to comm-central.

The following files can be removed along with the tests:

  • passwordManager.xhtml
  • passwordmgr.css
  • passwordManagerList.ftl
  • passwordManager.js

The following prefs can be removed:

  • signon.management.overrideURI
  • signon.management.page.enabled

We should also simplify LoginHelper.openPasswordManager to always open about:logins and not pass ?filter= when there is no filterString.

Flags: qe-verify+
Summary: Remove old password manager UI (passwordManager.xul) from mozilla-central → Remove old password manager UI (passwordManager.xhtml) from mozilla-central
Assignee: nobody → severin.mozilla
Status: NEW → ASSIGNED

As a side effect, this removes the need for bug 1537634.

Priority: P2 → P1
See Also: → 1627869
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/fbd06f30bb6d
remove old password manager UI. r=MattN,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Hey Matt,

  • the 2 mentioned prefs are no longer displayed in about:config.
  • about:logins is reached via "about:logins?entryPoint=mainmenu" instead of ""about:logins?filter=&entryPoint=mainmenu"

Is there any way to verify the removed files or it is not surfaced for QA manual check?

Flags: needinfo?(MattN+bmo)

Hey Timea,

I don't think there's any way for QA to verify that, but I've just double checked the source and passwordManager.xhtml, passwordmgr.css, passwordManagerList.ftl, and passwordManager.js have all been removed.

I hope that helps.

Flags: needinfo?(MattN+bmo)

Thank you Severin!
Marking it as verified-fixed on latest Nightly 77.0a1 (220-05-04) on WIndows10 and MacOS 10.13.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.