Closed Bug 1569113 Opened 3 months ago Closed 3 months ago

Port bug 1569253: Copy passwordManager.xul and the associated JS/CSS files to comm-central

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: jorgk, Assigned: Paenglab)

References

Details

Attachments

(2 files, 1 obsolete file)

Richard, is this something you could take? Let's copy it to comm/ somewhere, like viewSource.xul.

Flags: needinfo?(richard.marti)

Yes, I can do this.

Matthew, toolkit/components/passwordmgr/content/recipes.json stays in toolkit, correct?

Assignee: nobody → richard.marti
Flags: needinfo?(richard.marti) → needinfo?(MattN+bmo)

(In reply to Richard Marti (:Paenglab) from comment #2)

Matthew, toolkit/components/passwordmgr/content/recipes.json stays in toolkit, correct?

Correct. You will want passwordManager.xul, passwordmgr.css, passwordManagerList.ftl, and passwordManager.js along with tests (not sure if they work in TB).

You can also delete the MOZ_BUILD_APP_IS_BROWSER portions of passwordManager.xul and the related code for password import.

Flags: needinfo?(MattN+bmo)
Summary: Port bug XXX: Copy passwordManager.xul and the associated JS/CSS files to comm-central → Port bug 1569253: Copy passwordManager.xul and the associated JS/CSS files to comm-central

(In reply to Jorg K (GMT+2) from comment #1)

Richard, is this something you could take? Let's copy it to comm/ somewhere, like viewSource.xul.

SM doesn't use the passwordManager. I'll copy it to mail/components/preferences. This is where we use it.

This patch copies the PWmanager to our preferences directory. The import part is removed.

I haven't copied any test as I don't know what would work and what changes are needed. This should be done from one of our test expert.

This patch should already work in tree without the toolkit PWmanager removal as except the FTL file all files have small changes that allowed-dupes should be happy.

To make also the FTL file a bit different we could change the "Site" in the list header as we have not only sites in it but also oauth keys.

I suggest to change "Site" to "Server" or "Provider". Can you paste an entry with and oauth key here. I don't have one configured right now, is it oauth://something.gmail.com?

Attached image oauth-token.png

This string "Logins for the following sites are stored on your computer" should also change.

Thanks. Maybe "Provider" is best then. You could ask the UI people.

Alessandro, what do you mean about the comments 5 to 9? What string would fit best?

Flags: needinfo?(alessandro)

I think I'm with Jorg and "Provider" seems generic enough to encapsulate the various type of strings showed in that column.

Flags: needinfo?(alessandro)

Changed all "site" to "provider", also all IDs, function names and strings.

Jörg, what do you think, can we land it and add tests in a new bug?

Attachment #9081101 - Attachment is obsolete: true
Attachment #9082061 - Flags: review?(jorgk)
Comment on attachment 9082061 [details] [diff] [review]
1569113-copy-passwordManager.patch

Have you tried it? I get:
JavaScript error: about:preferences, line 1: TypeError: gPrivacyPane is undefined

And fact, none of the buttons on "Privacy & Security" work.

Also, please change the commit message to:
Bug 1569113 - Copy passwordManager.xul and associated JS/CSS files to comm-central before removal in bug 1569253. r=jorgk
Attachment #9082061 - Flags: review?(jorgk)

Damn, doesn't work without the patch either. What's going on?

Comment on attachment 9082061 [details] [diff] [review]
1569113-copy-passwordManager.patch

Sorry, as suggested on IRC I cleared out the "preferences" directory here:
obj-x86_64-pc-mingw32\dist\bin\chrome\messenger\content\messenger\preferences

Now it works. We might as well land it before it rots and take a look at the tests in another bug. I'll fix the commit message.
Attachment #9082061 - Flags: review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5c59fc2c5f5f
Copy passwordManager.xul and associated JS/CSS files to comm-central before removal in bug 1569253. r=jorgk

Status: NEW → RESOLVED
Closed: 3 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
You need to log in before you can comment on or make changes to this bug.