1569113 - Port bug 1569253: Copy passwordManager.xul and the associated JS/CSS files to comm-central

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jorg K (CEST = GMT+2)]

As per:
https://groups.google.com/d/msg/mozilla.dev.apps.thunderbird/vKODZFHoyns/FtKkf_wMDwAJ

Comment 1

[Jorg K (CEST = GMT+2)]

Richard, is this something you could take? Let's copy it to comm/ somewhere, like viewSource.xul.

Comment 2

[Richard Marti (:Paenglab)]

Yes, I can do this.

Matthew, toolkit/components/passwordmgr/content/recipes.json stays in toolkit, correct?

Comment 3

[Matthew N. [:MattN]]

(In reply to Richard Marti (:Paenglab) from comment #2)

Matthew, toolkit/components/passwordmgr/content/recipes.json stays in toolkit, correct?

Correct. You will want passwordManager.xul, passwordmgr.css, passwordManagerList.ftl, and passwordManager.js along with tests (not sure if they work in TB).

You can also delete the MOZ_BUILD_APP_IS_BROWSER portions of passwordManager.xul and the related code for password import.

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #1)

Richard, is this something you could take? Let's copy it to comm/ somewhere, like viewSource.xul.

SM doesn't use the passwordManager. I'll copy it to mail/components/preferences. This is where we use it.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: WIP: 1569113-copy-passwordManager.patch

This patch copies the PWmanager to our preferences directory. The import part is removed.

I haven't copied any test as I don't know what would work and what changes are needed. This should be done from one of our test expert.

This patch should already work in tree without the toolkit PWmanager removal as except the FTL file all files have small changes that allowed-dupes should be happy.

To make also the FTL file a bit different we could change the "Site" in the list header as we have not only sites in it but also oauth keys.

Comment 6

[Jorg K (CEST = GMT+2)]

I suggest to change "Site" to "Server" or "Provider". Can you paste an entry with and oauth key here. I don't have one configured right now, is it oauth://something.gmail.com?

Comment 7

[Richard Marti (:Paenglab)]

Attachment: oauth-token.png

Comment 8

[Jorg K (CEST = GMT+2)]

This string "Logins for the following sites are stored on your computer" should also change.

Comment 9

[Jorg K (CEST = GMT+2)]

Thanks. Maybe "Provider" is best then. You could ask the UI people.

Comment 10

[Richard Marti (:Paenglab)]

Alessandro, what do you mean about the comments 5 to 9? What string would fit best?

Comment 11

[Richard Marti (:Paenglab)]

Started a try to see how the tests pass with our own PW manager https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=3d367a3ff70462b725fe660dcda8a2a03ef1f8f8

Comment 12

[Alessandro Castellani [:aleca]]

I think I'm with Jorg and "Provider" seems generic enough to encapsulate the various type of strings showed in that column.

Comment 13

[Richard Marti (:Paenglab)]

Attachment: 1569113-copy-passwordManager.patch

Changed all "site" to "provider", also all IDs, function names and strings.

Jörg, what do you think, can we land it and add tests in a new bug?

Comment 14

[Jorg K (CEST = GMT+2)]

Comment on attachment 9082061 [details] [diff] [review]
1569113-copy-passwordManager.patch

Have you tried it? I get:
JavaScript error: about:preferences, line 1: TypeError: gPrivacyPane is undefined

And fact, none of the buttons on "Privacy & Security" work.

Also, please change the commit message to:
Bug 1569113 - Copy passwordManager.xul and associated JS/CSS files to comm-central before removal in bug 1569253. r=jorgk

Comment 15

[Jorg K (CEST = GMT+2)]

Damn, doesn't work without the patch either. What's going on?

Comment 16

[Jorg K (CEST = GMT+2)]

Comment on attachment 9082061 [details] [diff] [review]
1569113-copy-passwordManager.patch

Sorry, as suggested on IRC I cleared out the "preferences" directory here:
obj-x86_64-pc-mingw32\dist\bin\chrome\messenger\content\messenger\preferences

Now it works. We might as well land it before it rots and take a look at the tests in another bug. I'll fix the commit message.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5c59fc2c5f5f
Copy passwordManager.xul and associated JS/CSS files to comm-central before removal in bug 1569253. r=jorgk