Closed Bug 1569306 Opened 3 months ago Closed 3 months ago

[Export] Add trailhead cards, accessibile headers and bug fixes to New Tab Page

Categories

(Firefox :: New Tab Page, task, P2, enhancement)

task
P2
enhancement

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: [export])

Attachments

(1 file)

Summary: [Export] Add ... to New Tab Page → [Export] Add trailhead cards, accessibile headers and bug fixes to New Tab Page
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cb4cc20ea9d
Add trailhead cards, accessibile headers and bug fixes to New Tab Page r=k88hudson,fluent-reviewers,flod

Backed out changeset 2cb4cc20ea9d (Bug 1569306) for gecko decision bustage

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=2cb4cc20ea9d3de80bb5f1843258157fbb8ec6ba&selectedJob=258740001

Backout link: https://hg.mozilla.org/integration/autoland/rev/b8c129633b4e02ecab6e4d781b3c383a06ac963e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258740001&repo=autoland&lineNumber=4221

[task 2019-07-29T06:32:06.251Z] Generating tasks for release-update-verify-next firefox-next-win32
[task 2019-07-29T06:32:06.251Z] Generated 0 tasks for kind release-update-verify-next
[task 2019-07-29T06:32:06.251Z] Loading tasks for kind release-final-verify
[task 2019-07-29T06:32:06.257Z] Generating tasks for release-final-verify firefox
[task 2019-07-29T06:32:06.258Z] Generating tasks for release-final-verify devedition
[task 2019-07-29T06:32:06.259Z] Generated 2 tasks for kind release-final-verify
[task 2019-07-29T06:32:06.292Z] Generating full task graph
[task 2019-07-29T06:32:06.329Z] Full task graph contains 17511 tasks and 46034 dependencies
[task 2019-07-29T06:32:09.934Z] writing artifact file full-task-graph.json
[task 2019-07-29T06:32:16.293Z] writing artifact file runnable-jobs.json
[task 2019-07-29T06:32:16.788Z] Generating target task set
[task 2019-07-29T06:32:16.843Z] Filter filter_target_tasks pruned 15846 tasks (1665 remain)
[task 2019-07-29T06:32:16.843Z] writing artifact file target-tasks.json
[task 2019-07-29T06:32:16.845Z] Generating target task graph
[task 2019-07-29T06:32:16.866Z] Adding 0 tasks with always_target attribute
[task 2019-07-29T06:32:16.921Z] Generating optimized task graph
[task 2019-07-29T06:32:22.451Z] Reading file: /builds/worker/checkouts/gecko/moz.build
[task 2019-07-29T06:32:22.496Z] Reading file: /builds/worker/checkouts/gecko/browser/moz.build
[task 2019-07-29T06:32:22.500Z] Reading file: /builds/worker/checkouts/gecko/browser/components/moz.build
[task 2019-07-29T06:32:22.510Z] Reading file: /builds/worker/checkouts/gecko/browser/components/newtab/moz.build
[task 2019-07-29T06:32:22.517Z] Traceback (most recent call last):
[task 2019-07-29T06:32:22.517Z] File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 204, in taskgraph_decision
[task 2019-07-29T06:32:22.517Z] return taskgraph.decision.taskgraph_decision(options)
[task 2019-07-29T06:32:22.517Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 202, in taskgraph_decision
[task 2019-07-29T06:32:22.517Z] write_artifact('task-graph.json', tgg.morphed_task_graph.to_json())
[task 2019-07-29T06:32:22.517Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 201, in morphed_task_graph
[task 2019-07-29T06:32:22.517Z] return self._run_until('morphed_task_graph')
[task 2019-07-29T06:32:22.518Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 351, in _run_until
[task 2019-07-29T06:32:22.518Z] k, v = self._run.next()
[task 2019-07-29T06:32:22.518Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 337, in _run
[task 2019-07-29T06:32:22.518Z] strategies=strategies,
[task 2019-07-29T06:32:22.518Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 56, in optimize_task_graph
[task 2019-07-29T06:32:22.518Z] do_not_optimize=do_not_optimize)
[task 2019-07-29T06:32:22.518Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 126, in remove_tasks
[task 2019-07-29T06:32:22.518Z] if opt.should_remove_task(task, params, arg):
[task 2019-07-29T06:32:22.518Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 372, in should_remove_task
[task 2019-07-29T06:32:22.518Z] scheduled = self.scheduled_by_push(params['head_repository'], params['head_rev'])
[task 2019-07-29T06:32:22.518Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/util.py", line 961, in method_call
[task 2019-07-29T06:32:22.518Z] cache[args] = self.func(instance, *args)
[task 2019-07-29T06:32:22.518Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 363, in scheduled_by_push
[task 2019-07-29T06:32:22.518Z] for p, m in rdr.files_info(changed_files).items():
[task 2019-07-29T06:32:22.518Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1339, in files_info
[task 2019-07-29T06:32:22.519Z] paths, _ = self.read_relevant_mozbuilds(paths)
[task 2019-07-29T06:32:22.519Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1303, in read_relevant_mozbuilds
[task 2019-07-29T06:32:22.519Z] self.config, metadata=metadata):
[task 2019-07-29T06:32:22.519Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1057, in read_mozbuild
[task 2019-07-29T06:32:22.519Z] raise bre
[task 2019-07-29T06:32:22.520Z] BuildReaderError:
[task 2019-07-29T06:32:22.520Z] ==============================
[task 2019-07-29T06:32:22.520Z] FATAL ERROR PROCESSING MOZBUILD FILE
[task 2019-07-29T06:32:22.520Z] ==============================
[task 2019-07-29T06:32:22.520Z]
[task 2019-07-29T06:32:22.520Z] The error occurred while processing the following file:
[task 2019-07-29T06:32:22.520Z]
[task 2019-07-29T06:32:22.520Z] /builds/worker/checkouts/gecko/browser/components/newtab/moz.build
[task 2019-07-29T06:32:22.520Z]
[task 2019-07-29T06:32:22.520Z] The error was triggered on line 10 of this file:
[task 2019-07-29T06:32:22.520Z]
[task 2019-07-29T06:32:22.520Z] BROWSER_CHROME_MANIFESTS += ['test/browser/browser.ini']
[task 2019-07-29T06:32:22.520Z]
[task 2019-07-29T06:32:22.520Z] An error was encountered as part of executing the file itself. The error appears to be the fault of the script.
[task 2019-07-29T06:32:22.520Z]
[task 2019-07-29T06:32:22.520Z] The error as reported by Python is:
[task 2019-07-29T06:32:22.520Z]
[task 2019-07-29T06:32:22.520Z] ['AssertionError\n']
[task 2019-07-29T06:32:22.520Z]
[taskcluster 2019-07-29 06:32:23.224Z] === Task Finished ===
[taskcluster 2019-07-29 06:32:31.075Z] Unsuccessful task run with exit code: 1 completed in 67.424 seconds

Flags: needinfo?(edilee)
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4274af431ede
Add trailhead cards, accessibile headers and bug fixes to New Tab Page r=k88hudson,fluent-reviewers,flod

Patch didn't apply correctly on latest mozilla-central with lando. Rebasing the patch with git removed the duplicate skip-if = fission

Flags: needinfo?(edilee)
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Blocks: 1570745
Flags: needinfo?(mcoman)
Flags: needinfo?(cmuresan)
Flags: needinfo?(acupsa)

We have verified all the issues that were actionable from our point of view. Considering this I will remove the ni? request.

Flags: needinfo?(mcoman)
Flags: needinfo?(cmuresan)
Flags: needinfo?(acupsa)
You need to log in before you can comment on or make changes to this bug.