Closed Bug 1569370 Opened 2 years ago Closed 2 years ago

RLBox - Switch the RLBox API parameter to move to the sandboxed version of libGraphite

Categories

(Core :: Graphics, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: shravanrn, Assigned: froydnj, Mentored)

References

Details

Attachments

(1 file)

No description provided.
Summary: RLBox - Switch usage of libGraphite to the sandboxed version → RLBox - Switch the RLBox API parameter to move to the sandboxed version of libGraphite
Component: Javascript: WebAssembly → General
Component: General → Graphics
Depends on: 1573734
Depends on: 1576049
Depends on: 1572619
Depends on: 1576051
Depends on: 1576052
Depends on: 1575985
Depends on: 1577906
Depends on: 1605416
Depends on: 1605537

This patch is not ideal: if would be better to do the defaulting in
toolkit/moz.configure, but doing it there runs into problems with base
toolchain configurations, as the clang there is not new enough. So we
have this, doing everything with environment variables, which is easily
turned on or off, depending on the needs of the specific configuration.

The mozconfig.no-compile change is not really needed, as the wasm
sandboxing detection bits are not conditional on
--enable-compile-environment. Those bits should be, and I will tackle
doing that after the holidays.

Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c867ca4daf74
add mozconfig fragments for declaring wasm sandboxing bits; r=firefox-build-system-reviewers,rstewart

Backed out for build bustages

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=282455844&resultStatus=testfailed%2Cbusted%2Cexception&revision=c867ca4daf743532bea4e2912f112c6d7fff00c9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282455813&repo=autoland&lineNumber=1212

Backout: https://hg.mozilla.org/integration/autoland/rev/ffba2b42c83b51f66c0ab8c9a8e9c2130a7c570c

[task 2019-12-24T03:38:43.469Z] 03:38:43 INFO - checking for lucetc... not found
[task 2019-12-24T03:38:43.469Z] 03:38:43 INFO - DEBUG: lucetc: Trying /builds/worker/fetches/lucetc/lucetc
[task 2019-12-24T03:38:43.469Z] 03:38:43 INFO - ERROR: Cannot find lucetc
[task 2019-12-24T03:38:43.509Z] 03:38:43 INFO - *** Fix above errors and then restart with
[task 2019-12-24T03:38:43.509Z] 03:38:43 INFO - "./mach build"
[task 2019-12-24T03:38:43.509Z] 03:38:43 INFO - client.mk:111: recipe for target 'configure' failed
[task 2019-12-24T03:38:43.510Z] 03:38:43 INFO - make: *** [configure] Error 1
[task 2019-12-24T03:38:43.609Z] 03:38:43 ERROR - Return code: 2
[task 2019-12-24T03:38:43.609Z] 03:38:43 WARNING - setting return code to 2
[task 2019-12-24T03:38:43.609Z] 03:38:43 FATAL - 'mach configure' did not run successfully. Please check log for errors.
[task 2019-12-24T03:38:43.610Z] 03:38:43 FATAL - Running post_fatal callback...
[task 2019-12-24T03:38:43.610Z] 03:38:43 FATAL - Exiting -1

Flags: needinfo?(shravanrn)

I believe Nathan is working on this bug. Passing on the needimfo

Flags: needinfo?(shravanrn) → needinfo?(nfroyd)

(In reply to Alexandru Michis [:malexandru] from comment #5)

There are also web platform test failures related to the changeset which was backed out:
https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&searchStr=linux%2Cx64%2Casan%2Cweb%2Cplatform%2Ctests%2Ctest-linux64-asan%2Fopt-web-platform-tests-e10s-13%2Cw%28wpt13%29&tochange=bb6a839e1be40ec61beacf728f48411aa508ca2b&fromchange=5cd557d590e262c375af7912bd847e61454ed8d2&selectedJob=282456411

Shravan, can you look at this? I can easily take care of the build bustages, but this looks like bad interactions with the sandbox.

Flags: needinfo?(nfroyd) → needinfo?(shravanrn)

Sure, I can follow up in the next few hours.

@Nathan - The test that failed here is marked intermittent, which maybe why I didn't give it a second thought (if it cropped up earlier)t. Are you seeing anything that indicates this is RLBox related? I will continue investigating in my side.

Depends on: 1605875

Ah, found the point where this is rlbox related. Looking into this now

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282456411&repo=autoland&lineNumber=4817

So the errors seem slightly intermittent and easy to reproduce only on optimized asan builds... This will take me a couple of days to resolve.

Flags: needinfo?(shravanrn)
Depends on: 1605944
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/008852b3720d
add mozconfig fragments for declaring wasm sandboxing bits; r=firefox-build-system-reviewers,rstewart
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ad74aa6c596
Backed out changeset 008852b3720d for causing linux x64 wasm bustages CLOSED TREE

Passing on needinfo

@Nathan - I'm assuming this is something related to building graphite or build system upgrades and not due to my changes. Please let me know if you need any information or help from my side. Also, would you mind changing the assignee for this bug?

Flags: needinfo?(shravanrn) → needinfo?(nfroyd)

Looks like the build failures are due to some of pgo flags being passed on to the wasm compilation. Lucet doesn't support these, so they shouldn't be passed in for the graphite compilation.

(In reply to Shravan Narayan from comment #15)

Looks like the build failures are due to some of pgo flags being passed on to the wasm compilation. Lucet doesn't support these, so they shouldn't be passed in for the graphite compilation.

Yeah, this is it. I think it would be feasible to gather PGO data on libgraphitewasm.so, but I'm not confident that setting that up would go smoothly, so the easiest thing to do at the moment is just disable PGO on those files.

Flags: needinfo?(nfroyd)
Depends on: 1606625
Assignee: shravanrn → nfroyd
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/691de0626040
add mozconfig fragments for declaring wasm sandboxing bits; r=firefox-build-system-reviewers,rstewart
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla73 → ---
Regressions: 1606981
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b176ff2e6979
add mozconfig fragments for declaring wasm sandboxing bits; r=firefox-build-system-reviewers,rstewart
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.