1569370 - RLBox - Switch the RLBox API parameter to move to the sandboxed version of libGraphite

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1569370 - add mozconfig fragments for declaring wasm sandboxing bits; r=#build

This patch is not ideal: if would be better to do the defaulting in
toolkit/moz.configure, but doing it there runs into problems with base
toolchain configurations, as the clang there is not new enough. So we
have this, doing everything with environment variables, which is easily
turned on or off, depending on the needs of the specific configuration.

The mozconfig.no-compile change is not really needed, as the wasm
sandboxing detection bits are not conditional on
--enable-compile-environment. Those bits should be, and I will tackle
doing that after the holidays.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c867ca4daf74
add mozconfig fragments for declaring wasm sandboxing bits; r=firefox-build-system-reviewers,rstewart

Comment 3

[Andreea Pavel [:apavel]]

Backed out for build bustages

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=282455844&resultStatus=testfailed%2Cbusted%2Cexception&revision=c867ca4daf743532bea4e2912f112c6d7fff00c9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282455813&repo=autoland&lineNumber=1212

Backout: https://hg.mozilla.org/integration/autoland/rev/ffba2b42c83b51f66c0ab8c9a8e9c2130a7c570c

[task 2019-12-24T03:38:43.469Z] 03:38:43 INFO - checking for lucetc... not found
[task 2019-12-24T03:38:43.469Z] 03:38:43 INFO - DEBUG: lucetc: Trying /builds/worker/fetches/lucetc/lucetc
[task 2019-12-24T03:38:43.469Z] 03:38:43 INFO - ERROR: Cannot find lucetc
[task 2019-12-24T03:38:43.509Z] 03:38:43 INFO - *** Fix above errors and then restart with
[task 2019-12-24T03:38:43.509Z] 03:38:43 INFO - "./mach build"
[task 2019-12-24T03:38:43.509Z] 03:38:43 INFO - client.mk:111: recipe for target 'configure' failed
[task 2019-12-24T03:38:43.510Z] 03:38:43 INFO - make: *** [configure] Error 1
[task 2019-12-24T03:38:43.609Z] 03:38:43 ERROR - Return code: 2
[task 2019-12-24T03:38:43.609Z] 03:38:43 WARNING - setting return code to 2
[task 2019-12-24T03:38:43.609Z] 03:38:43 FATAL - 'mach configure' did not run successfully. Please check log for errors.
[task 2019-12-24T03:38:43.610Z] 03:38:43 FATAL - Running post_fatal callback...
[task 2019-12-24T03:38:43.610Z] 03:38:43 FATAL - Exiting -1

Comment 4

[Shravan Narayan]

I believe Nathan is working on this bug. Passing on the needimfo

Comment 5

[Alexandru Michis [:malexandru]]

There are also web platform test failures related to the changeset which was backed out:
https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&searchStr=linux%2Cx64%2Casan%2Cweb%2Cplatform%2Ctests%2Ctest-linux64-asan%2Fopt-web-platform-tests-e10s-13%2Cw%28wpt13%29&tochange=bb6a839e1be40ec61beacf728f48411aa508ca2b&fromchange=5cd557d590e262c375af7912bd847e61454ed8d2&selectedJob=282456411

Comment 6

[Nathan Froyd [:froydnj]]

(In reply to Alexandru Michis [:malexandru] from comment #5)

There are also web platform test failures related to the changeset which was backed out:
https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&searchStr=linux%2Cx64%2Casan%2Cweb%2Cplatform%2Ctests%2Ctest-linux64-asan%2Fopt-web-platform-tests-e10s-13%2Cw%28wpt13%29&tochange=bb6a839e1be40ec61beacf728f48411aa508ca2b&fromchange=5cd557d590e262c375af7912bd847e61454ed8d2&selectedJob=282456411

Shravan, can you look at this? I can easily take care of the build bustages, but this looks like bad interactions with the sandbox.

Comment 7

[Shravan Narayan]

Sure, I can follow up in the next few hours.

Comment 8

[Shravan Narayan]

@Nathan - The test that failed here is marked intermittent, which maybe why I didn't give it a second thought (if it cropped up earlier)t. Are you seeing anything that indicates this is RLBox related? I will continue investigating in my side.

Comment 9

[Shravan Narayan]

Ah, found the point where this is rlbox related. Looking into this now

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282456411&repo=autoland&lineNumber=4817

Comment 10

[Shravan Narayan]

So the errors seem slightly intermittent and easy to reproduce only on optimized asan builds... This will take me a couple of days to resolve.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/008852b3720d
add mozconfig fragments for declaring wasm sandboxing bits; r=firefox-build-system-reviewers,rstewart

Comment 12

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 008852b3720d (Bug 1569370) for causing linux x64 wasm bustages CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=282961671

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282961671&repo=autoland&lineNumber=25538

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ad74aa6c596
Backed out changeset 008852b3720d for causing linux x64 wasm bustages CLOSED TREE

Comment 14

[Shravan Narayan]

Passing on needinfo

@Nathan - I'm assuming this is something related to building graphite or build system upgrades and not due to my changes. Please let me know if you need any information or help from my side. Also, would you mind changing the assignee for this bug?

Comment 15

[Shravan Narayan]

Looks like the build failures are due to some of pgo flags being passed on to the wasm compilation. Lucet doesn't support these, so they shouldn't be passed in for the graphite compilation.

Comment 16

[Nathan Froyd [:froydnj]]

(In reply to Shravan Narayan from comment #15)

Looks like the build failures are due to some of pgo flags being passed on to the wasm compilation. Lucet doesn't support these, so they shouldn't be passed in for the graphite compilation.

Yeah, this is it. I think it would be feasible to gather PGO data on libgraphitewasm.so, but I'm not confident that setting that up would go smoothly, so the easiest thing to do at the moment is just disable PGO on those files.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/691de0626040
add mozconfig fragments for declaring wasm sandboxing bits; r=firefox-build-system-reviewers,rstewart

Comment 18

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/691de0626040

Comment 19

[Razvan Maries]

Backed out as per Nathan's request: https://hg.mozilla.org/integration/autoland/rev/be919a1220ea59b0656fee4e7ab73b18f2e055ee

Comment 20

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/be919a1220ea

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b176ff2e6979
add mozconfig fragments for declaring wasm sandboxing bits; r=firefox-build-system-reviewers,rstewart

Comment 22

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b176ff2e6979