1573734 - RLBox - Ensure libThebes can be safely compiled with c++17

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Shravan Narayan]

The RLBox requires compilation with c++ 17. Since we are changing libThebes to use RLBox, this must compiled with c++17. However, portions of libThebes such as some code specific to the Windows platform throws errors (which are warnings turned errors) when compiled with c++ 17, as listed here.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1573734 - prefer atomic_thread_fence in StyleArcInner::DecrementRef; r=emilio

This change is motivated by atomic::load being nodiscard on Windows
and atomic_thread_fence being closer to what Arc::drop and
ThreadSafeAutoRefCnt does. We keep the MOZ_TSAN refinement of
ThreadSafeAutoRefCnt as well.

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Shravan Narayan from comment #0)

The RLBox requires compilation with c++ 17. Since we are changing libThebes to use RLBox, this must compiled with c++17. However, portions of libThebes such as some code specific to the Windows platform throws errors (which are warnings turned errors) when compiled with c++ 17, as listed here.

NB: it's helpful to provide example errors inline in your bug reports, rather than relying on treeherder logs, as treeherder logs eventually expire, whereas Bugzilla comments do not.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba24cc998a46
prefer atomic_thread_fence in StyleArcInner::DecrementRef; r=emilio

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ba24cc998a46

Comment 5

[Shravan Narayan]

oh yay! that was quick :)

NB: it's helpful to provide example errors inline in your bug reports, rather than relying on treeherder logs, as treeherder logs eventually expire, whereas Bugzilla comments do not.

Noted.