1569478 - Empty white space below urlbar dropdown when one-off buttons are hidden after landing patch from bug #1551598

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bad.png

STR:

1. Have only 1 active One-Click Search Engine in Search tab ( about:preferences#search ) in Options ( about:preferences )
2. In Address Bar write "test"
   and see that there is more useless blank white space below urlbar dropdown in Address Bar after landing patch from bug #1551598

It's also not consistent with amount of blank white space above urlbar dropdown in Address Bar.

Regression caused by:
Bug #1551598 - Stop using a popup window for urlbar results. r=mak

Differential Revision:
https://phabricator.services.mozilla.com/D38988

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: good.png

Comment 2

[Marco Bonardo [:mak]]

Hm, one-off buttons are not visible there, did you disable them through the about:config pref?

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

See STR #1, as I have only 1 One-Click Search Engine, so there shouldn't be any buttons visible.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1569478 - Fix one-off search button hiding. r=mak

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ad0fb1caddd
Fix one-off search button hiding. r=mak

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5ad0fb1caddd

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 70.0a1 (2019-07-31), so I'm marking this bug as VERIFIED.
Thank you very much! \o/