1569515 - Expose overhead stats in profiler_get_buffer_info()

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

The profilers collect overhead data, but only output them in JSON outputs, making them a bit difficult to access.

Instead, these should also be available from profiler_get_buffer_info(), so that tests can easily display them; This can help verify overhead fixes during development.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1569515 - Collect overhead stats in ProfileBuffer - r?canaltinova

ProfileBuffer is now responsible for collecting overhead stats, and adding
them to the struct returned by profiler_get_buffer_info().

Depends on D39640

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1569515 - Show overhead stats in Profiler tests - r?canaltinova

cppunittest TestBaseProfiler and gtest GeckoProfiler.Markers now show overhead
stats.
(Separate patch, because we may want to remove them after a while.)

Depends on D39641

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50e6066912e6
Collect overhead stats in ProfileBuffer - r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/b8385abc9741
Show overhead stats in Profiler tests - r=canaltinova

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/50e6066912e6
https://hg.mozilla.org/mozilla-central/rev/b8385abc9741