Closed Bug 1569515 Opened 4 months ago Closed 4 months ago

Expose overhead stats in profiler_get_buffer_info()

Categories

(Core :: Gecko Profiler, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The profilers collect overhead data, but only output them in JSON outputs, making them a bit difficult to access.

Instead, these should also be available from profiler_get_buffer_info(), so that tests can easily display them; This can help verify overhead fixes during development.

ProfileBuffer is now responsible for collecting overhead stats, and adding
them to the struct returned by profiler_get_buffer_info().

Depends on D39640

cppunittest TestBaseProfiler and gtest GeckoProfiler.Markers now show overhead
stats.
(Separate patch, because we may want to remove them after a while.)

Depends on D39641

Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50e6066912e6
Collect overhead stats in ProfileBuffer - r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/b8385abc9741
Show overhead stats in Profiler tests - r=canaltinova
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.