1646613 - CollectOverheadStats is outputting microseconds but source incorrectly says "Ns"

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

See https://searchfox.org/mozilla-central/source/tools/profiler/core/ProfileBuffer.cpp#139-184
Variable names have an "Ns" suffix, but computations do X.ToMilliseconds() * 1000.0; and therefore are actually in microseconds.

Since we've been outputting these numbers forever, I propose that:

• We change the variable suffixes to "Us" to show the correct unit.
• The frontend should change the displayed units from "ns" to "µs": https://github.com/firefox-devtools/profiler/issues/2603

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1646613 - Rename profiler overhead variables to include their true unit - r?canaltinova

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56716cbb41d7
Rename profiler overhead variables to include their true unit - r=canaltinova

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/56716cbb41d7