1569705 - regression: Separate search bar dropdown is shifted to the left

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Asif Youssuff]

Attachment: search-bar-shift-left.PNG

Steps to reproduce:

1. Enable search bar in toolbar
2. type text into search bar

What happens:

The search panel that appears below the search box is shifted to the left of the input field.

Expected result:

The search panel/dropdown should be aligned to and the same width as the search input above it.

2019-07-29T18:02:44: INFO : Narrowed inbound regression window from [1dbf929c, fd26384a] (3 builds) to [1dbf929c, a29be90a] (2 builds) (~1 steps left)
2019-07-29T18:02:44: DEBUG : Starting merge handling...
2019-07-29T18:02:44: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=a29be90ae6089d1a7adac121c8596df7da2be243&full=1
2019-07-29T18:02:46: DEBUG : Found commit message:
Bug 1556561 - Remove <children> usage from autocomplete binding. r=dao,surkov

Differential Revision: https://phabricator.services.mozilla.com/D33568

2019-07-29T18:02:46: DEBUG : Did not find a branch, checking all integration branches
2019-07-29T18:02:46: INFO : The bisection is done.
2019-07-29T18:02:46: INFO : Stopped

Comment 1

[Asif Youssuff]

[Tracking Requested - why for this release]:

This is a regression in a very visible part of the Firefox UI.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1569705 - Stop unnecessarily setting left/right margins on searchbar autocomplete popup. r=jaws

This code now became obsolete and broken with the autocomplete popup being anchored to the textbox instead of the textbox inner input.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3e3ed30085e
Stop unnecessarily setting left/right margins on searchbar autocomplete popup. r=mak

Comment 4

[Tim Nguyen :ntim]

It would be nice if QA could review this change once it lands in Nightly so we can uplift this.

Since this is platform specific, we should check whether the popup is aligned correctly on all 3 platforms since this code is shared across platforms.

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 9081468 [details]
Bug 1569705 - Stop unnecessarily setting left/right margins on searchbar autocomplete popup. r=jaws

Beta/Release Uplift Approval Request

• User impact if declined: See comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0 and comment 4
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fairly small change affecting styling
• String changes made/needed: no

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c3e3ed30085e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9081468 [details]
Bug 1569705 - Stop unnecessarily setting left/right margins on searchbar autocomplete popup. r=jaws

Simple styling fix for the search bar autocomplete popup. Approved for 69.0b10.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3f26710d6f0e

Comment 9

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 70.0a1 (2019-07-29), on Windows 10 x64.
I can confirm this issue is fixed on Fx 70.0a1 (2019-08-01). I verified using Windows 10 x64, Ubuntu 16.04 LTS and macOS 10.13.

Comment 10

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm this issue is also fixed on Fx 69.0b10, I verified on the same environment as in comment 9.