1556561 - Remove <children> usage from autocomplete binding

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Tim Nguyen :ntim]

Two of them are specific to the browser searchbar, and the other one is unused. Doing this will allow us to decouple searchbar logic from the autocomplete binding, but also make the autocomplete binding markup more simple and closer to an actual HTML input.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1556561 - Remove <children> usage from autocomplete binding. r=dao,surkov

Comment 2

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fc0f0f3dcaef046edb5ab4fef12d8279ecf61a9

Comment 3

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=834f97e5abc91ce212724866d91f6c5ed8419d02

Newer one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=827af511082b06b9ac8ba959d66f933dcabea4fb

Comment 4

[Tim Nguyen :ntim]

I think TB will need to port this change over (if it lands):

<children includes="image|box"/>:

• https://searchfox.org/comm-central/source/mail/components/addrbook/content/abMailListDialog.xul#82
• https://searchfox.org/comm-central/source/mail/components/addrbook/content/abEditListDialog.xul#71

<children/>:

• https://searchfox.org/comm-central/source/editor/ui/dialogs/content/EdLinkProps.xul#46
• https://searchfox.org/comm-central/source/editor/ui/dialogs/content/EdImageProps.xul#47

For Firefox's only usage of <children includes="..."/>, I'm just moving out the children from the textbox and putting them as siblings.

For TB, some different ideas are:

• Moving out the actual children and putting them as siblings like Firefox
• Using background-image instead of <image src="person-icon"/>
• Temporarily creating a new binding that extends autocomplete, and that adds back the <children/> in the <content>

Comment 5

[Tim Nguyen :ntim]

Alternatively, if it's too much trouble to take care of now, I'm happy to keep <children/> and <children includes="image"/> (since TB only needs those 2) until bug 1534455 is fixed.

Comment 6

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1314b00eb1495a06b868f4eea0f30ffeeab5497d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a29be90ae608
Remove <children> usage from autocomplete binding. r=dao,surkov

Comment 8

[Magnus Melin [:mkmelin]]

(In reply to Tim Nguyen :ntim from comment #4)

I think TB will need to port this change over (if it lands):

Thanks, filed bug 1557978.

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a29be90ae608