1569948 - One-off search buttons missing if you click the Show history icon on the address bar and then type anything

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Itiel]

Attachment: Screenshot

Using Windows 10.

STR:

1. Use a Nightly build that was built before bug 1551598 got fixed.
2. (Optional, not sure if essential to the STR) Set intl.uidirection to 1 and restart
3. Update Nightly to latest
4. Type anything in the address bar

AR:
All of the one-off buttons are missing, and only "Search with" text and the cog icon are present.
Closing the autocomplete panel and reopening fixes this. This seems to be happening only on the first run after the update.

See attached.
This happened to me on my main profile at home the day after bug 1551598 got fixed, but I could reproduce this now on my (fairly) new profile at work (which was not updated in a while).

Comment 1

[Dão Gottwald [:dao]]

It doesn't seem to make sense that you'd need a pre-bug 1551598 build first. Can you reproduce without that point?

Comment 2

[Itiel]

Nope. No matter how I try, I can't reproduce it after the first time.

Note that I'm only speculating that this is regressed by bug 1551598, because that seem to be the only major address bar related change that got into Nightly a build after I've updated it.
I can try to reproduce with a third profile if needed but I guess the outcome will be the same.

Comment 3

[Itiel]

(In reply to Dão Gottwald [::dao] from comment #1)

It doesn't seem to make sense that you'd need a pre-bug 1551598 build first. Can you reproduce without that point?

Well, you're right.

New STR:

1. Windows 10, latest Nightly
2. Restart Nightly on a new tab
3. Click the "Show history" icon on the address bar
4. Start typing anything

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1569948 - Rebuild one-off search buttons when enabling them rather than when opening the view. r=mak

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71c23430e052
Rebuild one-off search buttons when enabling them rather than when opening the view. r=mak

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/71c23430e052

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm this issue is fixed on Fx 70.0, 71.0b3 and 72.0a1(ar builds).