Closed Bug 1570195 Opened 5 years ago Closed 3 years ago

Urlbar icon is too large when non square SVG is used

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- wontfix
firefox84 --- wontfix
firefox85 --- wontfix
firefox86 --- fixed

People

(Reporter: ntim, Assigned: amy)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot
251.58 KB, image/png
Details
Bug 1570195 - Update favicon to have width to avoid column overflow. r?harry
48 bytes, text/x-phabricator-request
Details | Review
Attached image Screenshot —

See the 3rd row in the screenshot.

Icon is at: https://janitor.technology/img/janitor.svg

Component: Themes → Address Bar
Product: Toolkit → Firefox
Priority: -- → P2

well, svg is indeed an exception, because the favicons service can't store a square icon in that case.
At least we can add back the rule with a comment explaining why it's necessary.

Severity: normal → S3
Severity: S3 → S4
Priority: P2 → P3
Points: --- → 1
Assignee: nobody → achurchwell
Status: NEW → ASSIGNED
Attachment #9194253 - Attachment description: Bug 1570195 - Update favicon to have max-width to avoid column overflow. r?harry → Bug 1570195 - Update favicon to have width to avoid column overflow. r?harry
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d67ebe52bbc1
Update favicon to have width to avoid column overflow. r=harry,ntim

https://hg.mozilla.org/mozilla-central/rev/d67ebe52bbc1

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: