Closed Bug 1570212 Opened 5 years ago Closed 5 years ago

Convert various VarCache prefs to static prefs

Tracking

()

Status:

RESOLVED FIXED

Milestone:

Firefox 70

Tracking Flags:

Tracking

Status

firefox70

---

fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(23 files)

Bug 1570212 - Convert privacy.firstparty.isolate* prefs to static prefs. r=tjr 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert dom.quotaManager.testing to a static pref. r=asuth 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert dom.quotaManager.temporaryStorage.* to static prefs. r=asuth 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert security.all_resource_uri_content_accessible to a static pref. r=tjr 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert three dom.ipc.* prefs into static prefs. r=mccr8 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert toolkit.telemetry.ipcBatchTimeout to a static pref. r=chutten 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert dom.allow_XUL_XBL_for_file to a static pref. r=mccr8 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert media.webrtc.net.force_disable_rtcp_reception to a static pref. r=jya 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert dom.testing.sync-content-blocking-notifications to a static pref. r=mccr8 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert geo.timeout to a static pref. r=mccr8 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert dom.events.dataTransfer.protected.enabled to a static pref. r=mccr8 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert dom.disable_window_print to a static pref. r=mccr8 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert device.sensors.test.events to a static pref. r=mccr8 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert dom.securecontext.whitelist_onions to a static pref. r=mccr8 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert browser.tabs.remote.force-paint to a static pref. r=mccr8 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert layout.reflow.synthMouseMove to a static pref. r=heycam 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert media.cloneElementVisually.testing to a static pref. r=jya 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert media.video_stats.enabled to a static pref. r=jya 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Convert content.cors.disable to a static pref. r=dragana 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Remove content.cors.no_private_data pref. r=dragana 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Make security.turn_off_all_security... a non-VarCache pref. r=mccr8 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Clean up `privacy.*` static pref definitions. r=tjr 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570212 - Remove `privacy.resistFingerprinting.*` VarCache prefs. r=tjr 5 years ago Nicholas Nethercote [inactive] 47 bytes, text/x-phabricator-request		Details \| Review

Nicholas Nethercote [inactive]

Assignee

Description

•

5 years ago

Specifically, ones where a VarCache is created when no pref value exists. These are blocking me from completing bug 1569526.

Nicholas Nethercote [inactive]

Assignee

Updated

•

5 years ago

Blocks: 1448219

Nicholas Nethercote [inactive]

Assignee

Comment 1

•

5 years ago

Attached file Bug 1570212 - Convert privacy.firstparty.isolate* prefs to static prefs. r=tjr — Details

Nicholas Nethercote [inactive]

Assignee

Comment 2

•

5 years ago

Attached file Bug 1570212 - Convert dom.quotaManager.testing to a static pref. r=asuth — Details

It's unused.

Depends on D40001

Nicholas Nethercote [inactive]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1570212 - Convert dom.quotaManager.temporaryStorage.* to static prefs. r=asuth — Details

Depends on D40002

Nicholas Nethercote [inactive]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1570212 - Convert security.all_resource_uri_content_accessible to a static pref. r=tjr — Details

Depends on D40003

Nicholas Nethercote [inactive]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1570212 - Convert three dom.ipc.* prefs into static prefs. r=mccr8 — Details

Depends on D40004

Nicholas Nethercote [inactive]

Assignee

Comment 6

•

5 years ago

Attached file Bug 1570212 - Convert toolkit.telemetry.ipcBatchTimeout to a static pref. r=chutten — Details

Depends on D40005

Phabricator Automation

Updated

•

5 years ago

Attachment #9081875 - Attachment description: Bug 1570212 - Remove the VarCache for the dom.quotaManager.testing pref. r=mccr8 → Bug 1570212 - Convert dom.quotaManager.testing to a static pref. r=asuth

Phabricator Automation

Updated

•

5 years ago

Attachment #9081876 - Attachment description: Bug 1570212 - Convert dom.quotaManager.temporaryStorage.* to static prefs. r=mccr8 → Bug 1570212 - Convert dom.quotaManager.temporaryStorage.* to static prefs. r=asuth

Nicholas Nethercote [inactive]

Assignee

Comment 7

•

5 years ago

Attached file Bug 1570212 - Convert dom.allow_XUL_XBL_for_file to a static pref. r=mccr8 — Details

Depends on D40006

Nicholas Nethercote [inactive]

Assignee

Comment 8

•

5 years ago

Attached file Bug 1570212 - Convert media.webrtc.net.force_disable_rtcp_reception to a static pref. r=jya — Details

Depends on D40153

Nicholas Nethercote [inactive]

Assignee

Comment 9

•

5 years ago

Attached file Bug 1570212 - Convert dom.testing.sync-content-blocking-notifications to a static pref. r=mccr8 — Details

Depends on D40154

Nicholas Nethercote [inactive]

Assignee

Comment 10

•

5 years ago

Attached file Bug 1570212 - Convert geo.timeout to a static pref. r=mccr8 — Details

Depends on D40155

Nicholas Nethercote [inactive]

Assignee

Comment 11

•

5 years ago

Attached file Bug 1570212 - Convert dom.events.dataTransfer.protected.enabled to a static pref. r=mccr8 — Details

Depends on D40156

Nicholas Nethercote [inactive]

Assignee

Comment 12

•

5 years ago

Attached file Bug 1570212 - Convert dom.disable_window_print to a static pref. r=mccr8 — Details

Depends on D40157

Nicholas Nethercote [inactive]

Assignee

Comment 13

•

5 years ago

Attached file Bug 1570212 - Convert device.sensors.test.events to a static pref. r=mccr8 — Details

Depends on D40158

Nicholas Nethercote [inactive]

Assignee

Comment 14

•

5 years ago

Attached file Bug 1570212 - Convert dom.securecontext.whitelist_onions to a static pref. r=mccr8 — Details

Depends on D40159

Nicholas Nethercote [inactive]

Assignee

Comment 15

•

5 years ago

Attached file Bug 1570212 - Convert browser.tabs.remote.force-paint to a static pref. r=mccr8 — Details

Depends on D40160

Nicholas Nethercote [inactive]

Assignee

Updated

•

5 years ago

Keywords: leave-open

Nicholas Nethercote [inactive]

Assignee

Updated

•

5 years ago

Blocks: 1569526

Pulsebot

Comment 16

•

5 years ago

Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62db71f2544d
Convert privacy.firstparty.isolate* prefs to static prefs. r=tjr
https://hg.mozilla.org/integration/autoland/rev/1ad56915268a
Convert dom.quotaManager.testing to a static pref. r=asuth
https://hg.mozilla.org/integration/autoland/rev/94aaa71664cb
Convert dom.quotaManager.temporaryStorage.* to static prefs. r=asuth
https://hg.mozilla.org/integration/autoland/rev/6774e173a05e
Convert security.all_resource_uri_content_accessible to a static pref. r=tjr
https://hg.mozilla.org/integration/autoland/rev/32d5b0eb343a
Convert three dom.ipc.* prefs into static prefs. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/3c246eb3943a
Convert toolkit.telemetry.ipcBatchTimeout to a static pref. r=chutten

Tom Ritter [:tjr] (OOTO until mid-August)

Updated

•

5 years ago

Blocks: 1567623

Nicholas Nethercote [inactive]

Assignee

Comment 17

•

5 years ago

Attached file Bug 1570212 - Convert layout.reflow.synthMouseMove to a static pref. r=heycam — Details

Depends on D40162

Nicholas Nethercote [inactive]

Assignee

Comment 18

•

5 years ago

Attached file Bug 1570212 - Convert media.cloneElementVisually.testing to a static pref. r=jya — Details

Depends on D40338

Nicholas Nethercote [inactive]

Assignee

Comment 19

•

5 years ago

Attached file Bug 1570212 - Convert media.video_stats.enabled to a static pref. r=jya — Details

Also remove HTMLVideoElement::InitStatics(), which is no longer needed.

Depends on D40339

Nicholas Nethercote [inactive]

Assignee

Comment 20

•

5 years ago

Attached file Bug 1570212 - Convert content.cors.disable to a static pref. r=dragana — Details

Depends on D40340

Nicholas Nethercote [inactive]

Assignee

Comment 21

•

5 years ago

Attached file Bug 1570212 - Remove content.cors.no_private_data pref. r=dragana — Details

It's never modified anywhere, and so there's no real point in having it.

The patch also removes the now-empty nsCORSListenerProxy::Startup().

Depends on D40341

Nicholas Nethercote [inactive]

Assignee

Comment 22

•

5 years ago

Attached file Bug 1570212 - Make security.turn_off_all_security... a non-VarCache pref. r=mccr8 — Details

As a result, it would become visible in about:config. So the patch also
modifies about:config so that doesn't happen.

Depends on D40342

Razvan Maries

Comment 23

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/62db71f2544d
https://hg.mozilla.org/mozilla-central/rev/1ad56915268a
https://hg.mozilla.org/mozilla-central/rev/94aaa71664cb
https://hg.mozilla.org/mozilla-central/rev/6774e173a05e
https://hg.mozilla.org/mozilla-central/rev/32d5b0eb343a
https://hg.mozilla.org/mozilla-central/rev/3c246eb3943a

Dão Gottwald [:dao]

Updated

•

5 years ago

Assignee: nobody → n.nethercote

Priority: -- → P1

Andrew McCreight [:mccr8]

Updated

•

5 years ago

Blocks: 1571121

Pulsebot

Comment 24

•

5 years ago

Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff00fe45c3d2
Convert dom.allow_XUL_XBL_for_file to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a035512b4f44
Convert media.webrtc.net.force_disable_rtcp_reception to a static pref. r=jya
https://hg.mozilla.org/integration/autoland/rev/0502c02439eb
Convert dom.testing.sync-content-blocking-notifications to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/09628a9faf59
Convert geo.timeout to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/ce74181517ed
Convert dom.events.dataTransfer.protected.enabled to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0e363460f740
Convert dom.disable_window_print to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0ecc35590409
Convert device.sensors.test.events to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/57c05745399b
Convert dom.securecontext.whitelist_onions to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/533cf0ae7f5e
Convert browser.tabs.remote.force-paint to a static pref. r=mccr8

Pulsebot

Comment 25

•

5 years ago

Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae1e48d740a7
Convert layout.reflow.synthMouseMove to a static pref. r=heycam
https://hg.mozilla.org/integration/autoland/rev/8e72c66c3076
Convert media.cloneElementVisually.testing to a static pref. r=jya
https://hg.mozilla.org/integration/autoland/rev/bb1723162580
Convert media.video_stats.enabled to a static pref. r=jya

Cristian Brindusan [:cbrindusan]

Comment 26

•

5 years ago

bugherder

Phabricator Automation

Updated

•

5 years ago

Attachment #9082479 - Attachment description: Bug 1570212 - Convert security.turn_off_all_security... to a static pref. r=mccr8,paolo → Bug 1570212 - Make security.turn_off_all_security... a non-VarCache pref. r=mccr8

Nicholas Nethercote [inactive]

Assignee

Comment 27

•

5 years ago

Attached file Bug 1570212 - Clean up `privacy.*` static pref definitions. r=tjr — Details

Fix overly-long lines, add '.' to the end of sentences, put things in a more
sensible order, etc. (No functional changes.)

Depends on D40343

Nicholas Nethercote [inactive]

Assignee

Comment 28

•

5 years ago

Attached file Bug 1570212 - Remove `privacy.resistFingerprinting.*` VarCache prefs. r=tjr — Details

The patch also removes RFP_TIMER_VALUE_DEFAULT and RFP_JITTER_VALUE_DEFAULT
because they are unused.

Depends on D40903

Phabricator Automation

Updated

•

5 years ago

Attachment #9082477 - Attachment description: Bug 1570212 - Convert content.cors.disable to a static pref. r=michal → Bug 1570212 - Convert content.cors.disable to a static pref. r=dragana

Phabricator Automation

Updated

•

5 years ago

Attachment #9082478 - Attachment description: Bug 1570212 - Remove content.cors.no_private_data pref. r=michal → Bug 1570212 - Remove content.cors.no_private_data pref. r=dragana

Phabricator Automation

Updated

•

5 years ago

Attachment #9083513 - Attachment description: Bug 1570212 - Convert `privacy.resistFingerprinting.*` to static prefs. r=tjr → Bug 1570212 - Remove `privacy.resistFingerprinting.*` VarCache prefs. r=tjr

Nicholas Nethercote [inactive]

Assignee

Updated

•

5 years ago

Keywords: leave-open

Pulsebot

Comment 29

•

5 years ago

Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c76bbd0f9a43
Convert content.cors.disable to a static pref. r=dragana
https://hg.mozilla.org/integration/autoland/rev/df1b7d72c13e
Remove content.cors.no_private_data pref. r=dragana
https://hg.mozilla.org/integration/autoland/rev/3fcd5e2f0344
Make security.turn_off_all_security... a non-VarCache pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/bc6225570e8b
Clean up `privacy.*` static pref definitions. r=tjr
https://hg.mozilla.org/integration/autoland/rev/6f0426e233d6
Remove `privacy.resistFingerprinting.*` VarCache prefs. r=tjr

Narcis Beleuzu [:NarcisB]

Comment 30

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/c76bbd0f9a43
https://hg.mozilla.org/mozilla-central/rev/df1b7d72c13e
https://hg.mozilla.org/mozilla-central/rev/3fcd5e2f0344
https://hg.mozilla.org/mozilla-central/rev/bc6225570e8b
https://hg.mozilla.org/mozilla-central/rev/6f0426e233d6

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox70: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 70

You need to log in before you can comment on or make changes to this bug.