1570212 - Convert various VarCache prefs to static prefs

Status: RESOLVED FIXED

(Firefox :: General, task, P1)

Description

[Nicholas Nethercote [inactive]]

Specifically, ones where a VarCache is created when no pref value exists. These are blocking me from completing bug 1569526.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert privacy.firstparty.isolate* prefs to static prefs. r=tjr

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert dom.quotaManager.testing to a static pref. r=asuth

It's unused.

Depends on D40001

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert dom.quotaManager.temporaryStorage.* to static prefs. r=asuth

Depends on D40002

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert security.all_resource_uri_content_accessible to a static pref. r=tjr

Depends on D40003

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert three dom.ipc.* prefs into static prefs. r=mccr8

Depends on D40004

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert toolkit.telemetry.ipcBatchTimeout to a static pref. r=chutten

Depends on D40005

Comment 7

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert dom.allow_XUL_XBL_for_file to a static pref. r=mccr8

Depends on D40006

Comment 8

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert media.webrtc.net.force_disable_rtcp_reception to a static pref. r=jya

Depends on D40153

Comment 9

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert dom.testing.sync-content-blocking-notifications to a static pref. r=mccr8

Depends on D40154

Comment 10

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert geo.timeout to a static pref. r=mccr8

Depends on D40155

Comment 11

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert dom.events.dataTransfer.protected.enabled to a static pref. r=mccr8

Depends on D40156

Comment 12

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert dom.disable_window_print to a static pref. r=mccr8

Depends on D40157

Comment 13

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert device.sensors.test.events to a static pref. r=mccr8

Depends on D40158

Comment 14

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert dom.securecontext.whitelist_onions to a static pref. r=mccr8

Depends on D40159

Comment 15

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert browser.tabs.remote.force-paint to a static pref. r=mccr8

Depends on D40160

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62db71f2544d
Convert privacy.firstparty.isolate* prefs to static prefs. r=tjr
https://hg.mozilla.org/integration/autoland/rev/1ad56915268a
Convert dom.quotaManager.testing to a static pref. r=asuth
https://hg.mozilla.org/integration/autoland/rev/94aaa71664cb
Convert dom.quotaManager.temporaryStorage.* to static prefs. r=asuth
https://hg.mozilla.org/integration/autoland/rev/6774e173a05e
Convert security.all_resource_uri_content_accessible to a static pref. r=tjr
https://hg.mozilla.org/integration/autoland/rev/32d5b0eb343a
Convert three dom.ipc.* prefs into static prefs. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/3c246eb3943a
Convert toolkit.telemetry.ipcBatchTimeout to a static pref. r=chutten

Comment 17

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert layout.reflow.synthMouseMove to a static pref. r=heycam

Depends on D40162

Comment 18

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert media.cloneElementVisually.testing to a static pref. r=jya

Depends on D40338

Comment 19

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert media.video_stats.enabled to a static pref. r=jya

Also remove HTMLVideoElement::InitStatics(), which is no longer needed.

Depends on D40339

Comment 20

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Convert content.cors.disable to a static pref. r=dragana

Depends on D40340

Comment 21

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Remove content.cors.no_private_data pref. r=dragana

It's never modified anywhere, and so there's no real point in having it.

The patch also removes the now-empty nsCORSListenerProxy::Startup().

Depends on D40341

Comment 22

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Make security.turn_off_all_security... a non-VarCache pref. r=mccr8

As a result, it would become visible in about:config. So the patch also
modifies about:config so that doesn't happen.

Depends on D40342

Comment 23

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/62db71f2544d
https://hg.mozilla.org/mozilla-central/rev/1ad56915268a
https://hg.mozilla.org/mozilla-central/rev/94aaa71664cb
https://hg.mozilla.org/mozilla-central/rev/6774e173a05e
https://hg.mozilla.org/mozilla-central/rev/32d5b0eb343a
https://hg.mozilla.org/mozilla-central/rev/3c246eb3943a

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff00fe45c3d2
Convert dom.allow_XUL_XBL_for_file to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a035512b4f44
Convert media.webrtc.net.force_disable_rtcp_reception to a static pref. r=jya
https://hg.mozilla.org/integration/autoland/rev/0502c02439eb
Convert dom.testing.sync-content-blocking-notifications to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/09628a9faf59
Convert geo.timeout to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/ce74181517ed
Convert dom.events.dataTransfer.protected.enabled to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0e363460f740
Convert dom.disable_window_print to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0ecc35590409
Convert device.sensors.test.events to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/57c05745399b
Convert dom.securecontext.whitelist_onions to a static pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/533cf0ae7f5e
Convert browser.tabs.remote.force-paint to a static pref. r=mccr8

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae1e48d740a7
Convert layout.reflow.synthMouseMove to a static pref. r=heycam
https://hg.mozilla.org/integration/autoland/rev/8e72c66c3076
Convert media.cloneElementVisually.testing to a static pref. r=jya
https://hg.mozilla.org/integration/autoland/rev/bb1723162580
Convert media.video_stats.enabled to a static pref. r=jya

Comment 26

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ff00fe45c3d2
https://hg.mozilla.org/mozilla-central/rev/a035512b4f44
https://hg.mozilla.org/mozilla-central/rev/0502c02439eb
https://hg.mozilla.org/mozilla-central/rev/09628a9faf59
https://hg.mozilla.org/mozilla-central/rev/ce74181517ed
https://hg.mozilla.org/mozilla-central/rev/0e363460f740
https://hg.mozilla.org/mozilla-central/rev/0ecc35590409
https://hg.mozilla.org/mozilla-central/rev/57c05745399b
https://hg.mozilla.org/mozilla-central/rev/533cf0ae7f5e
https://hg.mozilla.org/mozilla-central/rev/ae1e48d740a7
https://hg.mozilla.org/mozilla-central/rev/8e72c66c3076
https://hg.mozilla.org/mozilla-central/rev/bb1723162580

Comment 27

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Clean up `privacy.*` static pref definitions. r=tjr

Fix overly-long lines, add '.' to the end of sentences, put things in a more
sensible order, etc. (No functional changes.)

Depends on D40343

Comment 28

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570212 - Remove `privacy.resistFingerprinting.*` VarCache prefs. r=tjr

The patch also removes RFP_TIMER_VALUE_DEFAULT and RFP_JITTER_VALUE_DEFAULT
because they are unused.

Depends on D40903

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c76bbd0f9a43
Convert content.cors.disable to a static pref. r=dragana
https://hg.mozilla.org/integration/autoland/rev/df1b7d72c13e
Remove content.cors.no_private_data pref. r=dragana
https://hg.mozilla.org/integration/autoland/rev/3fcd5e2f0344
Make security.turn_off_all_security... a non-VarCache pref. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/bc6225570e8b
Clean up `privacy.*` static pref definitions. r=tjr
https://hg.mozilla.org/integration/autoland/rev/6f0426e233d6
Remove `privacy.resistFingerprinting.*` VarCache prefs. r=tjr

Comment 30

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c76bbd0f9a43
https://hg.mozilla.org/mozilla-central/rev/df1b7d72c13e
https://hg.mozilla.org/mozilla-central/rev/3fcd5e2f0344
https://hg.mozilla.org/mozilla-central/rev/bc6225570e8b
https://hg.mozilla.org/mozilla-central/rev/6f0426e233d6