Closed Bug 1571121 Opened 3 years ago Closed 3 years ago

Change Window.print() from using Func to Pref

Categories

(Core :: DOM: Core & HTML, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

In bug 1570212, njn is converting dom.disable_window_print into a static pref. It is used by nsGlobalWindowInner::IsWindowPrintEnabled(). If we flip the pref to be dom.enable_window_print, then the WebIDL Func property that calls this method can be changed into a Pref property that simply checks the pref directly.

This can be done by changing the pref from being enable instead of disable.

This pref was added in bug 739038. Skimming that, I don't see any particular reason why it needs to be disable instead of enable. That seems to just be what other similar prefs did.

Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ed17d4710d9
Change Window.print() from using Func to Pref. r=bzbarsky

I wonder if the pref is used at some enterprises or in kiosk mode browsers.

I've never seen folks reference needing this pref and if so, we could just add the new version in policy.

(In reply to Olli Pettay [:smaug] from comment #4)

I wonder if the pref is used at some enterprises or in kiosk mode browsers.

I googled for the pref, and didn't find any references aside from instances in the source code, if that indicates anything.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.