1571121 - Change Window.print() from using Func to Pref

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Andrew McCreight [:mccr8]]

In bug 1570212, njn is converting dom.disable_window_print into a static pref. It is used by nsGlobalWindowInner::IsWindowPrintEnabled(). If we flip the pref to be dom.enable_window_print, then the WebIDL Func property that calls this method can be changed into a Pref property that simply checks the pref directly.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1571121 - Change Window.print() from using Func to Pref.

This can be done by changing the pref from being enable instead of disable.

Comment 2

[Andrew McCreight [:mccr8]]

This pref was added in bug 739038. Skimming that, I don't see any particular reason why it needs to be disable instead of enable. That seems to just be what other similar prefs did.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ed17d4710d9
Change Window.print() from using Func to Pref. r=bzbarsky

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I wonder if the pref is used at some enterprises or in kiosk mode browsers.

Comment 5

[Mike Kaply [:mkaply]]

I've never seen folks reference needing this pref and if so, we could just add the new version in policy.

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Olli Pettay [:smaug] from comment #4)

I wonder if the pref is used at some enterprises or in kiosk mode browsers.

I googled for the pref, and didn't find any references aside from instances in the source code, if that indicates anything.

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/5ed17d4710d9