Closed Bug 1570248 Opened 6 years ago Closed 5 years ago

Stop using --lwt-background-tab-separator-color for the separator between the tracking protection and identity icons

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: dao, Assigned: timhuang)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [privacy-panel][skyline])

Attachments

(1 file)

Bug 1570248 - Change the color of the separator after the shield icon. r?johannh!
47 bytes, text/x-phabricator-request
Details | Review

As you can tell by its name, --lwt-background-tab-separator-color is not at all the right color to use here, and will randomly fail to produce reasonable results depending on the specific webextension theme colors.

Blocks: protections-panel

--urlbar-separator-color is what you'd want to use here.

Priority: P2 → --
Whiteboard: [privacy-panel][skyline]
Priority: -- → P1
Assignee: nobody → tihuang

The patch changes the color of the separator after the shield to use
variable '--urlbar-separator-color' instead of the variable
'--lwt-background-tab-separator-color'. And it removes the opacity.

Status: NEW → ASSIGNED
Pushed by tihuang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af78e873d1e8 Change the color of the separator after the shield icon. r=johannh

https://hg.mozilla.org/mozilla-central/rev/af78e873d1e8

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: