1570357 - Profiler toolbar icon is not showing up when the pref is set by --setpref during firefox startup

Status: NEW

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Sometimes people want to set the popup pref by hand during the firefox startup by --setpref(e.g. to profile the startup of a new firefox profile). But when we set the devtools.performance.popup.enabled pref to true, we can't see the popup in the navbar currently. The popup should be visible when this pref is set by hand.
STR:

• Run firefox with ./mach run --temp-profile --setpref "devtools.performance.popup.enabled=true"

Expected Result:

• The should be a profiler toolbar icon on the top right side of the navbar

Actual Result:

• No profiler toolbar icon :(

This is happening because we are not running this line during startup: https://searchfox.org/mozilla-central/source/devtools/client/performance-new/popup/menu-button.jsm#56
Only initialize function is being run during startup, we should also have a mechanism that add the widget to navbar if it's not added already.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I did encounter this, but didn't file a bug then, because it felt like maybe the --setpref thing was too much of a hack. But if it could be done, that would be great.

Also, we have bug 1566921 which is about enabling the icon when starting with MOZ_PROFILER_STARTUP=1.
Whichever can be done first would be a nice start for (I think) most usages.

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Yeah, that would also be great. Probably if we fix that bug, enabling the icon on MOZ_PROFILER_STARTUP=1 will be much more easier (we can just set that pref to true and it's done :) )

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Greg, I think it's more your area.

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

cc:greg -- What do you think?