1570492 - browser.topSites.get({ newtab: true }) should prefer sites' labels to titles

Status: RESOLVED FIXED

(WebExtensions :: General, task, P1)

Description

[Drew Willcoxon :adw]

Users can set custom titles for their top sites using the edit functionality of the newtab page. Custom titles are stored in the label property. browser.topSites.get({ newtab: true }) uses label for search shortcuts but not for other links. That means that the user's custom titles aren't reflected in the non-search-shortcut sites returned from get.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1570492 - Make browser.topSites.get({ newtab: true }) prefer sites' labels to titles.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4b8877a8838
Make browser.topSites.get({ newtab: true }) prefer sites' labels to titles. r=mixedpuppy

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e4b8877a8838

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 9082095 [details]
Bug 1570492 - Make browser.topSites.get({ newtab: true }) prefer sites' labels to titles.

Beta/Release Uplift Approval Request

• User impact if declined: This bug supports the top-sites experiment that the quantumbar/search team would like to conduct on 69.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch affects only the new newtab option that we recently added to the browser.topSites API and uplifted in bug 1568617. It doesn't affect any existing browser.topSites API consumers/extensions.
• String changes made/needed: None

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9082095 [details]
Bug 1570492 - Make browser.topSites.get({ newtab: true }) prefer sites' labels to titles.

Looks like this is low risk, approved for 69 beta 12, thanks.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/440c7ba936c5