157051 - Implement Use Selection for Find

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Wade Cosgrove]

As per Aqua human interface guidelines, command-E should be used to enter the
current selection into the find panel (or clipboard). Currently command-E loads
the current page in the source viewer. This has a tendency to get a little
annoying if you're used to using command-E for searching. :)

Comment 1

[Greg K.]

Wade, can you provide a URL to the relevent HIG section?

Comment 2

[Steve Smart]

cmd-E is the shortcut to be used if your app has a Use Selection for Find menu
item, however it is neither a reserved nor recommended shortcut, so we can feel
free to use it for whatever we want. If we ever implement a Use Selection for
Find item, then that definitely should get cmd-E and we would have to remap View
Source.

Comment 3

[Steve Smart]

Command-E is now neither reserved nor recommended in the Jaguar Aqua Human
Interface Guidelines (pg. 177-8), so I think this could be resolved.

Comment 4

[sairuh (rarely reading bugmail)]

see also bug 160777 comment 1.

Comment 5

[Max Horn]

*** This bug has been marked as a duplicate of 160777 ***

Comment 6

[sairuh (rarely reading bugmail)]

v

Comment 7

[S Woodside]

Reopening, because it's such a useful feature.

Comment 8

[Samuel Sidler (old account; do not CC)]

This doesn't seem like it'd be that hard, however, I'm not a programmer.

CCing Wevah to take a look at it and targetting for 1.0.

Comment 9

[Mike Pinkerton (not reading bugmail)]

fixed. also fixed a bug where the first time we'd load the find panel, we
wouldn't pick up the find string from the pasteboard.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

How is this supposed to work?  I have to make a selection, cmd-E, then cmd-F to
open a search panel populated with the selection.  

I would have expected cmd-E to open a search panel populated with the selection
if the panel wasn't already open (one-step); it seems like cmd-E only updates
the term in an existing panel or stores-to-later-populate when no panel is open.

Comment 11

[Samuel Sidler (old account; do not CC)]

I agree with Smokey's comments. That's the way this feature should work. Should
we open a new bug to change the current behavior?

Comment 12

[Paul Borokhov (lensovet)]

(In reply to comment #10)
> How is this supposed to work?  I have to make a selection, cmd-E, then cmd-F to
> open a search panel populated with the selection.  

Sadly, this is even how it works in TextEdit on panther. i agree that it seems
rather useless (to make it a two-step process), but then again, if we're going
for HIG, then there's no need for change.

a little weird though, i agree.

Comment 13

[Mike Pinkerton (not reading bugmail)]

this is how it works in any other app that supports it

cmd-e to get the text string into the "search" buffer
cmd-g to find it (find again). 

no dialog needed. we might want to rename to "find next" but it's the same thing.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #13)
> we might want to rename to "find next" but it's the same thing.

Except it also works for find previous, I see.  

Since the feature does the same thing under the same name in Apple apps, either
everyone knows what it does or is equally confused in those apps.  Oh well.  I
just wish Apple had chosen a more accurately descriptive name like "Store
Selection for Find" or "Use Selection for Finding" to begin with.