1570549 - Refactor SDP parsers so that they share a common interface

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

The two SDP parser interfaces used by JSEP only partially share a common interface. It would be good to extract the remaining interface and hide the SDP parser choosing logic from JSEP. This is being undertaken as a prerequisite for adding a pref to determine which parser to use as the primary and which, if any, to use as the fallback.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=35eac12d7ca1ad364929b7ccc30a5a52b43d1e32

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bd3e59100340579cdcab4f940f6a76e3aad3150

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1570549 - P1 - refactor into common SDP parser interface - r?bwc

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1570549 - P2 - refactor unit tests - r?bwc

Depends on D52323

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1570549 - P3 - Add SDP logger; r?bwc

Depends on D52324

Comment 6

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1570549 - P4 - Refactor parsing comparison entry point - r?bwc

Depends on D52325

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1570549 - P5 - Adding shim SDP parsing interface with pref controls - r?bwc

Depends on D52326

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1570549 - P6 - Use hybrid parser in JsepSessionImpl; r?bwc

Depends on D52327

Comment 9

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1570549 - P7 - Add SDP pref defaults; r?bwc

Depends on D52328

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=159bb51caabd83561d8f24d138eb6ddb5f1d3615

Comment 11

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c15147b0c5f73636b4bd9af3c1dda6627681b596

Comment 12

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1570549 - P8 - Restore SDP comparison telemetry;r?bwc

Depends on D52329

Comment 13

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c4d85f17837143efc3eeea3ac6f2fb26b568bad

Comment 14

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9402a82d3f7a7f6c9b746a76e69451ce21e876ef

Comment 15

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7d6acb1814eb489416e8d0965ee1dfdadf26c68

Comment 16

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=add6cb9419b0253671049b348bdf0ca949b9afe1

Comment 17

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d2b04c552187a730179d4d0d6268b86dcd594ec

Comment 18

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e168d88f40886ea2c1db9c5118fd37534c807031

Comment 19

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5558d10c26a6de2e3408aa3479bc85f73b0c6b1

Comment 20

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb559d130057413fa4441c4788fe53b469fb8c06

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94df2bb99c20
P1 - refactor into common SDP parser interface - r=bwc
https://hg.mozilla.org/integration/autoland/rev/dc0e0e020273
P2 - refactor unit tests - r=bwc
https://hg.mozilla.org/integration/autoland/rev/ac4ef8625479
P3 - Add SDP logger; r=bwc
https://hg.mozilla.org/integration/autoland/rev/3bfbbda57d4c
P4 - Refactor parsing comparison entry point - r=bwc
https://hg.mozilla.org/integration/autoland/rev/629c2fec174c
P5 - Adding shim SDP parsing interface with pref controls - r=bwc
https://hg.mozilla.org/integration/autoland/rev/0817d4ca061d
P6 - Use hybrid parser in JsepSessionImpl; r=bwc
https://hg.mozilla.org/integration/autoland/rev/19c2658031e2
P7 - Add SDP pref defaults; r=bwc
https://hg.mozilla.org/integration/autoland/rev/0574444bda48
P8 - Restore SDP comparison telemetry;r=bwc

Comment 22

[Noemi Erli[:noemi_erli]]

Backed out 8 changesets (Bug 1570549) for causing build bustages in sdp_unittests.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=277770123&resultStatus=testfailed%2Cbusted%2Cexception&revision=0574444bda4879ee8a9c76389b7f496485e248f9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277770123&repo=autoland&lineNumber=18107

Backout: https://hg.mozilla.org/integration/autoland/rev/0a6131fd4b414edba68e592c4377cedf820c5cd3

Comment 23

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9508f2b70b941682cb7f2ca4ea6967a17cd39c4d

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94346355a426
P1 - refactor into common SDP parser interface - r=bwc
https://hg.mozilla.org/integration/autoland/rev/3364ed9a7862
P2 - refactor unit tests - r=bwc
https://hg.mozilla.org/integration/autoland/rev/1435516b2085
P3 - Add SDP logger; r=bwc
https://hg.mozilla.org/integration/autoland/rev/3469d786723d
P4 - Refactor parsing comparison entry point - r=bwc
https://hg.mozilla.org/integration/autoland/rev/e0dbf967bc68
P5 - Adding shim SDP parsing interface with pref controls - r=bwc
https://hg.mozilla.org/integration/autoland/rev/d328f63d66a8
P6 - Use hybrid parser in JsepSessionImpl; r=bwc
https://hg.mozilla.org/integration/autoland/rev/7d4be5f410c9
P7 - Add SDP pref defaults; r=bwc
https://hg.mozilla.org/integration/autoland/rev/1d487300d143
P8 - Restore SDP comparison telemetry;r=bwc

Comment 25

[Cristian Brindusan [:cbrindusan]]

Backed out 8 changesets (Bug 1570549) for wpt failures at RTCTrackEvent-fire.html.
https://hg.mozilla.org/integration/autoland/rev/61be65ca42450c3fa5a76074efd48381ce5017cf

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=1d487300d14334a88974dfc2a19f425781bf916c&selectedJob=277802420

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277802420&repo=autoland&lineNumber=6154

Comment 26

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a912c67d1b54280348d7de1445cccbd25c9e9827

Comment 27

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=31ebde2462abd4a9f6602b7c74ef05983122bc9e

Comment 28

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d6ca3a6177de6fea36e145e4aca3c93a337b3a5

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55ada588cabf
P1 - refactor into common SDP parser interface - r=bwc
https://hg.mozilla.org/integration/autoland/rev/c589c8cc3984
P2 - refactor unit tests - r=bwc
https://hg.mozilla.org/integration/autoland/rev/201d03159e13
P3 - Add SDP logger; r=bwc
https://hg.mozilla.org/integration/autoland/rev/bb1c40e72951
P4 - Refactor parsing comparison entry point - r=bwc
https://hg.mozilla.org/integration/autoland/rev/f604cd9bd448
P5 - Adding shim SDP parsing interface with pref controls - r=bwc
https://hg.mozilla.org/integration/autoland/rev/5f17c4b33695
P6 - Use hybrid parser in JsepSessionImpl; r=bwc
https://hg.mozilla.org/integration/autoland/rev/70dc2a95ff71
P7 - Add SDP pref defaults; r=bwc
https://hg.mozilla.org/integration/autoland/rev/fba17efeb06c
P8 - Restore SDP comparison telemetry;r=bwc

Comment 30

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/55ada588cabf
https://hg.mozilla.org/mozilla-central/rev/c589c8cc3984
https://hg.mozilla.org/mozilla-central/rev/201d03159e13
https://hg.mozilla.org/mozilla-central/rev/bb1c40e72951
https://hg.mozilla.org/mozilla-central/rev/f604cd9bd448
https://hg.mozilla.org/mozilla-central/rev/5f17c4b33695
https://hg.mozilla.org/mozilla-central/rev/70dc2a95ff71
https://hg.mozilla.org/mozilla-central/rev/fba17efeb06c