Closed Bug 1570549 Opened 5 years ago Closed 5 years ago

Refactor SDP parsers so that they share a common interface

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla72

Tracking Flags:

Tracking

Status

firefox72

---

fixed

People

(Reporter: ng, Assigned: ng)

References

(Blocks 4 open bugs)

Details

Attachments

(8 files)

Bug 1570549 - P1 - refactor into common SDP parser interface - r?bwc 5 years ago Nico Grunbaum [:ng, @chew:mozilla.org] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570549 - P2 - refactor unit tests - r?bwc 5 years ago Nico Grunbaum [:ng, @chew:mozilla.org] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570549 - P3 - Add SDP logger; r?bwc 5 years ago Nico Grunbaum [:ng, @chew:mozilla.org] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570549 - P4 - Refactor parsing comparison entry point - r?bwc 5 years ago Nico Grunbaum [:ng, @chew:mozilla.org] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570549 - P5 - Adding shim SDP parsing interface with pref controls - r?bwc 5 years ago Nico Grunbaum [:ng, @chew:mozilla.org] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570549 - P6 - Use hybrid parser in JsepSessionImpl; r?bwc 5 years ago Nico Grunbaum [:ng, @chew:mozilla.org] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570549 - P7 - Add SDP pref defaults; r?bwc 5 years ago Nico Grunbaum [:ng, @chew:mozilla.org] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1570549 - P8 - Restore SDP comparison telemetry;r?bwc 5 years ago Nico Grunbaum [:ng, @chew:mozilla.org] 47 bytes, text/x-phabricator-request		Details \| Review

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Description

•

5 years ago

The two SDP parser interfaces used by JSEP only partially share a common interface. It would be good to extract the remaining interface and hide the SDP parser choosing logic from JSEP. This is being undertaken as a prerequisite for adding a pref to determine which parser to use as the primary and which, if any, to use as the fallback.

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 1

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=35eac12d7ca1ad364929b7ccc30a5a52b43d1e32

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Updated

•

5 years ago

Blocks: 1569002

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Updated

•

5 years ago

Blocks: 1594847

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 2

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bd3e59100340579cdcab4f940f6a76e3aad3150

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1570549 - P1 - refactor into common SDP parser interface - r?bwc — Details

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1570549 - P2 - refactor unit tests - r?bwc — Details

Depends on D52323

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1570549 - P3 - Add SDP logger; r?bwc — Details

Depends on D52324

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 6

•

5 years ago

Attached file Bug 1570549 - P4 - Refactor parsing comparison entry point - r?bwc — Details

Depends on D52325

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 7

•

5 years ago

Attached file Bug 1570549 - P5 - Adding shim SDP parsing interface with pref controls - r?bwc — Details

Depends on D52326

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 8

•

5 years ago

Attached file Bug 1570549 - P6 - Use hybrid parser in JsepSessionImpl; r?bwc — Details

Depends on D52327

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 9

•

5 years ago

Attached file Bug 1570549 - P7 - Add SDP pref defaults; r?bwc — Details

Depends on D52328

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Updated

•

5 years ago

Blocks: 1595161

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Updated

•

5 years ago

Blocks: 1595214

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 10

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=159bb51caabd83561d8f24d138eb6ddb5f1d3615

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 11

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c15147b0c5f73636b4bd9af3c1dda6627681b596

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 12

•

5 years ago

Attached file Bug 1570549 - P8 - Restore SDP comparison telemetry;r?bwc — Details

Depends on D52329

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 13

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c4d85f17837143efc3eeea3ac6f2fb26b568bad

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 14

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9402a82d3f7a7f6c9b746a76e69451ce21e876ef

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 15

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7d6acb1814eb489416e8d0965ee1dfdadf26c68

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Updated

•

5 years ago

Blocks: 1597603

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 16

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=add6cb9419b0253671049b348bdf0ca949b9afe1

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Updated

•

5 years ago

Blocks: 1598366

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 17

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d2b04c552187a730179d4d0d6268b86dcd594ec

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 18

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e168d88f40886ea2c1db9c5118fd37534c807031

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 19

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5558d10c26a6de2e3408aa3479bc85f73b0c6b1

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 20

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb559d130057413fa4441c4788fe53b469fb8c06

Pulsebot

Comment 21

•

5 years ago

Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/94df2bb99c20
P1 - refactor into common SDP parser interface - r=bwc
https://hg.mozilla.org/integration/autoland/rev/dc0e0e020273
P2 - refactor unit tests - r=bwc
https://hg.mozilla.org/integration/autoland/rev/ac4ef8625479
P3 - Add SDP logger; r=bwc
https://hg.mozilla.org/integration/autoland/rev/3bfbbda57d4c
P4 - Refactor parsing comparison entry point - r=bwc
https://hg.mozilla.org/integration/autoland/rev/629c2fec174c
P5 - Adding shim SDP parsing interface with pref controls - r=bwc
https://hg.mozilla.org/integration/autoland/rev/0817d4ca061d
P6 - Use hybrid parser in JsepSessionImpl; r=bwc
https://hg.mozilla.org/integration/autoland/rev/19c2658031e2
P7 - Add SDP pref defaults; r=bwc
https://hg.mozilla.org/integration/autoland/rev/0574444bda48
P8 - Restore SDP comparison telemetry;r=bwc

Noemi Erli[:noemi_erli]

Comment 22

•

5 years ago

Backed out 8 changesets (Bug 1570549) for causing build bustages in sdp_unittests.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=277770123&resultStatus=testfailed%2Cbusted%2Cexception&revision=0574444bda4879ee8a9c76389b7f496485e248f9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277770123&repo=autoland&lineNumber=18107

Backout: https://hg.mozilla.org/integration/autoland/rev/0a6131fd4b414edba68e592c4377cedf820c5cd3

Flags: needinfo?(na-g)

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 23

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9508f2b70b941682cb7f2ca4ea6967a17cd39c4d

Pulsebot

Comment 24

•

5 years ago

Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/94346355a426
P1 - refactor into common SDP parser interface - r=bwc
https://hg.mozilla.org/integration/autoland/rev/3364ed9a7862
P2 - refactor unit tests - r=bwc
https://hg.mozilla.org/integration/autoland/rev/1435516b2085
P3 - Add SDP logger; r=bwc
https://hg.mozilla.org/integration/autoland/rev/3469d786723d
P4 - Refactor parsing comparison entry point - r=bwc
https://hg.mozilla.org/integration/autoland/rev/e0dbf967bc68
P5 - Adding shim SDP parsing interface with pref controls - r=bwc
https://hg.mozilla.org/integration/autoland/rev/d328f63d66a8
P6 - Use hybrid parser in JsepSessionImpl; r=bwc
https://hg.mozilla.org/integration/autoland/rev/7d4be5f410c9
P7 - Add SDP pref defaults; r=bwc
https://hg.mozilla.org/integration/autoland/rev/1d487300d143
P8 - Restore SDP comparison telemetry;r=bwc

Cristian Brindusan [:cbrindusan]

Comment 25

•

5 years ago

Backed out 8 changesets (Bug 1570549) for wpt failures at RTCTrackEvent-fire.html.
https://hg.mozilla.org/integration/autoland/rev/61be65ca42450c3fa5a76074efd48381ce5017cf

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=1d487300d14334a88974dfc2a19f425781bf916c&selectedJob=277802420

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277802420&repo=autoland&lineNumber=6154

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 26

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a912c67d1b54280348d7de1445cccbd25c9e9827

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 27

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=31ebde2462abd4a9f6602b7c74ef05983122bc9e

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Updated

•

5 years ago

Blocks: 1598923

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Comment 28

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d6ca3a6177de6fea36e145e4aca3c93a337b3a5

Pulsebot

Comment 29

•

5 years ago

Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/55ada588cabf
P1 - refactor into common SDP parser interface - r=bwc
https://hg.mozilla.org/integration/autoland/rev/c589c8cc3984
P2 - refactor unit tests - r=bwc
https://hg.mozilla.org/integration/autoland/rev/201d03159e13
P3 - Add SDP logger; r=bwc
https://hg.mozilla.org/integration/autoland/rev/bb1c40e72951
P4 - Refactor parsing comparison entry point - r=bwc
https://hg.mozilla.org/integration/autoland/rev/f604cd9bd448
P5 - Adding shim SDP parsing interface with pref controls - r=bwc
https://hg.mozilla.org/integration/autoland/rev/5f17c4b33695
P6 - Use hybrid parser in JsepSessionImpl; r=bwc
https://hg.mozilla.org/integration/autoland/rev/70dc2a95ff71
P7 - Add SDP pref defaults; r=bwc
https://hg.mozilla.org/integration/autoland/rev/fba17efeb06c
P8 - Restore SDP comparison telemetry;r=bwc

Dorel Luca [:dluca]

Comment 30

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/55ada588cabf
https://hg.mozilla.org/mozilla-central/rev/c589c8cc3984
https://hg.mozilla.org/mozilla-central/rev/201d03159e13
https://hg.mozilla.org/mozilla-central/rev/bb1c40e72951
https://hg.mozilla.org/mozilla-central/rev/f604cd9bd448
https://hg.mozilla.org/mozilla-central/rev/5f17c4b33695
https://hg.mozilla.org/mozilla-central/rev/70dc2a95ff71
https://hg.mozilla.org/mozilla-central/rev/fba17efeb06c

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox72: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla72

Nico Grunbaum [:ng, @chew:mozilla.org]

Assignee

Updated

•

5 years ago

Flags: needinfo?(na-g)

Julien Cristau [:jcristau]

Updated

•

5 years ago

Regressions: 1599052

Alexandru Ionescu (needinfo me) [:alexandrui]

Updated

•

4 years ago

Regressions: 1601561

You need to log in before you can comment on or make changes to this bug.