1570568 - Update FxA toolbar menu to reflect the decoupling of FxA and Sync

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, enhancement)

Description

[Ryan Kelly [:rfkelly]]

Per Bug 1570565, we aim to decouple "Signing in to Firefox" from "Enabling Firefox Sync". The FxA toolbar menu will need to be updated to reflect three main potential states:

• The user is not signed in to Firefox
• The user is signed in to Firefox, but has not enabled Firefox Sync
• The user is signed in to Firefox and is syncing their data

:rfeeley has some initial designs for this but they're not final, I believe the next action here is to get to finalized designs.

Comment 1

[Ana Medinac]

I'm not sure if it's necessary or if the UI would be different but for the first state, we could break it up even further to:

• The user is not signed in to Firefox, and has an account
• The user is not signed in to Firefox, and has no account

Comment 2

[Ryan Kelly [:rfkelly]]

The user is not signed in to Firefox, and has an account

It's not clear to me how the browser would know this (or perhaps, whether the browser should know this).

I suppose the browser could peek into the user's browsing activity (such as history of visited URLs, or localStorage on accounts.firefox.com) and try to guess whether they've been using a Firefox Account to sign in to things on the web. Or we could have accounts.firefox.com send a special message to the browser to tell it about signin activity on the web. But we'll have to be careful about blurring the distinction between browser state and web content here.

Comment 3

[Ryan Kelly [:rfkelly]]

But we'll have to be careful about blurring the distinction between browser state and web content here.

This could be a good opportunity for CFR to advertize signin and Sync to users without going "full Google" and linking signin state between Browser and Web Content. If we can see from local browser state that the user has recently signed in to a web property using FxA, we could annotate the toolbar icon with that little blue dot and, if the user clicks on it, show some help text about how they've got an account and can now easily sync things across devices.

Comment 4

[Edouard Oger [:eoger]]

Work to do:

• Remove menu items, add Sync status menu item, change strings. See https://docs.google.com/document/d/1HivpoRdZBrt-59lLuU9dJPsTrn95hOvgCpFjVouk6IM/edit#heading=h.7nq9fw8b6x1d
• Expose the SYNC ON/OFF state in the toolbar by reading the sync username pref? (confirm w/ Markh).

Ref: https://docs.google.com/document/d/1HivpoRdZBrt-59lLuU9dJPsTrn95hOvgCpFjVouk6IM/edit#heading=h.feen7mi8j9s

Comment 5

[Vijay Budhram]

Attachment: Bug 1570568 - Update Fxa menu to reflect decoupling

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2053e82f159
Update Fxa menu to reflect decoupling r=eoger,markh

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b2053e82f159

Comment 8

[Vasilica Tamas, QA [:vtamas]]

Compared the FxA toolbar menu (and Hamburger menu) with the mock-ups (https://mozilla.invisionapp.com/share/C9TF95Q8GJM#/screens/378655927 and https://docs.google.com/document/d/1HivpoRdZBrt-59lLuU9dJPsTrn95hOvgCpFjVouk6IM/edit#) and it seems that the menu correctly reflects all three potential states except one thing:

• For a fresh profile, or when the user is signed in but the sync is turned off, Sync menu option appears as “Set up Sync” and not as “Sync” together with “Off” status. I did not found any decision about this change. Could someone confirm that “Set up Sync” is the final version?

Verified on Firefox 71.0a1 (2019-10-10) under Windows 10 64-bit and Mac OS X 10.14.6.