Closed Bug 1575706 Opened 5 years ago Closed 5 years ago

Add account submenu to FxA toolbar menu

Categories

(Firefox :: Firefox Accounts, enhancement)

Product:
Firefox
Component:
Firefox Accounts
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox71 --- verified

People

(Reporter: eoger, Assigned: vbudhram)

References

Details

(Whiteboard: [fxa])

Attachments

(1 file)

Bug 1575706 - Add account sub menu to fxa toolbar menu
47 bytes, text/x-phabricator-request
Details | Review

This is a small change that can land faster than the bigger FxA toolbar menu refactor.

Reference: https://docs.google.com/document/d/1HivpoRdZBrt-59lLuU9dJPsTrn95hOvgCpFjVouk6IM/edit#heading=h.r8hfu0tsieg5

Blocks: 1571526
No longer depends on: 1571526
Pushed by vbudhram@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ce6c9d4041a Add account sub menu to fxa toolbar menu r=eoger,markh

Backed out changeset 4ce6c9d4041a (bug 1575706) for failing at browser_duplicateIDs.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/35504ba51b51e9d3729e53ee19f4f03a53810902

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=4ce6c9d4041a0ed36ebe9f8998a6e02ca4fc6526&selectedJob=267514373

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267514373&repo=autoland&lineNumber=5824

Log snippet:
[task 2019-09-19T21:27:15.933Z] 21:27:15 INFO - TEST-PASS | browser/base/content/test/general/browser_duplicateIDs.js | fxa-menu-service-separator should be unique -
[task 2019-09-19T21:27:15.934Z] 21:27:15 INFO - TEST-PASS | browser/base/content/test/general/browser_duplicateIDs.js | PanelUI-fxa-menu-monitor-button should be unique -
[task 2019-09-19T21:27:15.934Z] 21:27:15 INFO - TEST-PASS | browser/base/content/test/general/browser_duplicateIDs.js | PanelUI-fxa-menu-send-button should be unique -
[task 2019-09-19T21:27:15.940Z] 21:27:15 INFO - TEST-PASS | browser/base/content/test/general/browser_duplicateIDs.js | PanelUI-fxa-menu-account-panel should be unique -
[task 2019-09-19T21:27:15.942Z] 21:27:15 INFO - TEST-PASS | browser/base/content/test/general/browser_duplicateIDs.js | PanelUI-fxa-menu-account-settings-button should be unique -
[task 2019-09-19T21:27:15.942Z] 21:27:15 INFO - Buffered messages finished
[task 2019-09-19T21:27:15.943Z] 21:27:15 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_duplicateIDs.js | fxa-menu-service-separator should be unique -
[task 2019-09-19T21:27:15.943Z] 21:27:15 INFO - Stack trace:
[task 2019-09-19T21:27:15.943Z] 21:27:15 INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2019-09-19T21:27:15.944Z] 21:27:15 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_duplicateIDs.js:test/<:7
[task 2019-09-19T21:27:15.944Z] 21:27:15 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_duplicateIDs.js:test:3
[task 2019-09-19T21:27:15.945Z] 21:27:15 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1387
[task 2019-09-19T21:27:15.945Z] 21:27:15 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1213
[task 2019-09-19T21:27:15.945Z] 21:27:15 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-09-19T21:27:15.946Z] 21:27:15 INFO - TEST-PASS | browser/base/content/test/general/browser_duplicateIDs.js | fxa-menu-device-name-label should be unique -
[task 2019-09-19T21:27:15.946Z] 21:27:15 INFO - TEST-PASS | browser/base/content/test/general/browser_duplicateIDs.js | PanelUI-fxa-menu-account-devices-button should be unique -
[task 2019-09-19T21:27:15.947Z] 21:27:15 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-09-19T21:27:15.947Z] 21:27:15 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_duplicateIDs.js | fxa-menu-service-separator should be unique -
[task 2019-09-19T21:27:15.947Z] 21:27:15 INFO - Stack trace:
[task 2019-09-19T21:27:15.948Z] 21:27:15 INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2019-09-19T21:27:15.948Z] 21:27:15 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_duplicateIDs.js:test/<:7
[task 2019-09-19T21:27:15.949Z] 21:27:15 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_duplicateIDs.js:test:3
[task 2019-09-19T21:27:15.949Z] 21:27:15 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1387
[task 2019-09-19T21:27:15.949Z] 21:27:15 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1213
[task 2019-09-19T21:27:15.950Z] 21:27:15 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-09-19T21:27:15.951Z] 21:27:15 INFO - TEST-PASS | browser/base/content/test/general/browser_duplicateIDs.js | PanelUI-fxa-menu-account-signout-button should be unique -

Flags: needinfo?(vbudhram)

Sorry about that, I've made the fix and kicked off a mach try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=23de2d506ab2b1ca23854443139978197c6b9f9c

If that goes well I'll try to land again.

Flags: needinfo?(vbudhram)
Pushed by vbudhram@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/378901831720 Add account sub menu to fxa toolbar menu r=eoger,markh

https://hg.mozilla.org/mozilla-central/rev/378901831720

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Whiteboard: [fxa]

Verified with 71.0b12 on Windows 10, macOS 10.15, Ubuntu 18.04.

Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified
Flags: qe-verify+
Regressions: 1701529
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: