1570598 - Some cleanup in toolchain scripts

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1570598 - Use GECKO_PATH instead of WORKSPACE/build/src in tooltool-download.sh.

This removes the need for the hacks in wr-macos-cross-build-setup.sh and
wrench-windows-tests.sh, while keeping things working in other scripts.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1570598 - Make windows clang toolchain tasks download artifact from GECKO_PATH.

This makes the setup used by these builds more similar to everywhere
else, making subsequent improvements easier.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1570598 - Use a common setup file for Visual Studio in toolchain scripts.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1570598 - Consistently use GECKO_PATH and MOZ_FETCHES_DIR in toolchain scripts.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1570598 - Remove redundant definitions of build-clang.py as a resource.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1570598 - Pass the clang json file as an argument to the toolchain script.

Make the argument use the same format as resources, so move the
sub-script invocation accordingly.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1570598 - Reduce the number of scripts used to build clang toolchains.

They are now all very similar, and there are only a few variations.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df44a0c0a833
Use GECKO_PATH instead of WORKSPACE/build/src in tooltool-download.sh. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1b63c61c922
Make windows clang toolchain tasks download artifact from GECKO_PATH. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a47df1713c3
Use a common setup file for Visual Studio in toolchain scripts. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/597f5f848988
Consistently use GECKO_PATH and MOZ_FETCHES_DIR in toolchain scripts. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/958362a7c300
Remove redundant definitions of build-clang.py as a resource. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/277229c8a6ce
Pass the clang json file as an argument to the toolchain script. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d66a096d9e2
Reduce the number of scripts used to build clang toolchains. r=froydnj

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/df44a0c0a833
https://hg.mozilla.org/mozilla-central/rev/b1b63c61c922
https://hg.mozilla.org/mozilla-central/rev/4a47df1713c3
https://hg.mozilla.org/mozilla-central/rev/597f5f848988
https://hg.mozilla.org/mozilla-central/rev/958362a7c300
https://hg.mozilla.org/mozilla-central/rev/277229c8a6ce
https://hg.mozilla.org/mozilla-central/rev/9d66a096d9e2