Closed
Bug 1570696
Opened 5 years ago
Closed 5 years ago
Move all the logic of the disconnection message out of Toolbox class
Categories
(DevTools :: about:debugging, task, P3)
DevTools
about:debugging
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
Today, the toolbox listen for target's close event. This practice gets in the way of bug 1565263, where the toolbox shouldn't be destroyed when the target is destroyed.
Instead, it should only be destroyed if the toolbox is explicitely closed by the user.
At least that's what we want for regular toolboxes.
about:debugging may keep its own way of managing the toolbox lifetime, but it would be great if that logic was outside of the base toolbox class.
As we make progress on process switch of web pages, we will most likely want to also support this for remote connection as well. So that we will most likely have to followup on the moved code, so that we also no longer destroy the toolbox when a target is destroyed because of a process switch.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Type: enhancement → task
Priority: -- → P3
|
||
Updated•5 years ago
|
Attachment #9082292 -
Attachment description: Bug 1570696 - Keep disconnection error message logic in toolbox-init. → Bug 1570696 - Destroy Toolbox on TabClose event for local tab targets.
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0e3a4fb87da3 Destroy Toolbox on TabClose event for local tab targets. r=jdescottes
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•