1570696 - Move all the logic of the disconnection message out of Toolbox class

Status: RESOLVED FIXED

(DevTools :: about:debugging, task, P3)

Description

[Alexandre Poirot [:ochameau]]

Today, the toolbox listen for target's close event. This practice gets in the way of bug 1565263, where the toolbox shouldn't be destroyed when the target is destroyed.
Instead, it should only be destroyed if the toolbox is explicitely closed by the user.
At least that's what we want for regular toolboxes.
about:debugging may keep its own way of managing the toolbox lifetime, but it would be great if that logic was outside of the base toolbox class.
As we make progress on process switch of web pages, we will most likely want to also support this for remote connection as well. So that we will most likely have to followup on the moved code, so that we also no longer destroy the toolbox when a target is destroyed because of a process switch.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1570696 - Destroy Toolbox on TabClose event for local tab targets.

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44c47f0dcd8cb5b9853ee5ece9f94944ab20d79d

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e3a4fb87da3
Destroy Toolbox on TabClose event for local tab targets. r=jdescottes

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0e3a4fb87da3