1536144 - Add a workaround to the server to detect that a device has been unplugged

Status: RESOLVED DUPLICATE of bug 1570696

(DevTools :: about:debugging, enhancement, P3)

Description

[Belén [:ladybenko]]

Follow up to bug: 1505368

The server is not throwing an exception when a remote device has been disconnected, and thus we are not detecting it and can't redirect to the error page in about:devtools-toolbox.

This patch by :daisuke shows a workaround in protocol.js for this issue, however :ochameau suggested to find a better place for throwing the exception (see discussion in Phabricator):

you are using a private of conn object. If we do want to throw immediately, we should do this from this class rather than here. We already do that here: https://searchfox.org/mozilla-central/source/devtools/shared/client/debugger-client.js#345-351 But I don't think that protocol.js goes through this codepath. Instead I think we are bypassing this request method by calling the underlying transport (via private!!) here: https://searchfox.org/mozilla-central/source/devtools/shared/protocol.js#1364-1372 So that, this Front.send would be a better place for such exception.

Comment 1

[Julian Descottes [:jdescottes]]

If Bug 1570696 lands, this should be closed as invalid.

Comment 2

[Julian Descottes [:jdescottes]]

No longer needed after Bug 1570696