1570727 - Clicking on an awesomebar result, but not the text, doesn't navigate to the page

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
Click on the (down) arrow within the location bar
In the popup, click your mouse on a suggestion but not on the text. Try to click within the top 5px of a suggestion.
Notice that the result is displayed as hovered.

AR:
The click is ignored and the popup stays open.

ER:
The page for the result is navigated to and the popup closes.

Comment 1

[Marco Bonardo [:mak]]

which OS? I can't reproduce on Win10

Comment 2

[Drew Willcoxon :adw]

I can't reproduce this on macOS either.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Marco Bonardo [::mak] (Away 7-25 Aug) from comment #1)

which OS? I can't reproduce on Win10

(In reply to Drew Willcoxon :adw from comment #2)

I can't reproduce this on macOS either.

Same here on Ubuntu.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Sorry, I can reproduce this on 70.0a1 (2019-08-02) (64-bit) Nightly on Windows 10.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

I can only reproduce this with the Bookmarks Toolbar visible.

Comment 6

[Marco Bonardo [:mak]]

I have the bookmarks toolbar visible on the same version. Do you have any userchrome changes? Would you mind trying in a new profile or safe mode? I really can't see this bug, thus there must be something additional to make it happen.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

You might need to maximize your window to reproduce it. I always use a maximized window when browsing so didn't think of it, but when using a restored window I can't reproduce it anymore.

Comment 8

[Drew Willcoxon :adw]

I just reproduced this on Windows. It happens only for the first result, and with the window both maximized and non-maximized. I'll try to debug.

Comment 9

[Drew Willcoxon :adw]

Clicks are being sent to the bookmarks toolbar instead of the panel. You can actually click the top part of the first result and drag the window around.

Comment 10

[Drew Willcoxon :adw]

Removing -moz-window-dragging: inherit from #personal-bookmarks fixes it.

Comment 11

[Drew Willcoxon :adw]

On macOS, clicks are sent to both the first result and the toolbar. You can drag the window, and on mouseup, the first result registers the click. You can also open the toolbar context menu on the first result (on both Windows and macOS).

Comment 12

[Drew Willcoxon :adw]

I haven't had much time to work on this since I took the bug, so if anyone else would like to steal it, feel free. I started by trying to figure out how clicks originate in widget and how they end up being dispatched to the toolbar frame. We/I should probably ask someone who actually knows about that. I saw mconley had blame for some lines in widget that handle window dragging, so I thought I'd ask him, but he's away this week.

As a last resort, we could maybe remove -moz-window-dragging: inherit from #personal-bookmarks while the view is open and add it back once it closes.

Comment 15

[Marco Bonardo [:mak]]

(In reply to Drew Willcoxon :adw from comment #12)

As a last resort, we could maybe remove -moz-window-dragging: inherit from #personal-bookmarks while the view is open and add it back once it closes.

Imo, that rule should only be applied when #personal-bookmarks is outside PersonalToolbar. Afaict the original bug was that moving bookmarks onto the menubar didn't allow to drag the window anymore.

Comment 16

[Marco Bonardo [:mak]]

I can investigate this a little bit, if you wish, though not at the platform level.

Comment 17

[Drew Willcoxon :adw]

Sure, feel free to take it. I probably won't work on it for the next few days.

Comment 18

[Marco Bonardo [:mak]]

Attachment: Bug 1570727 - Clicking on the first Address Bar result fails with the bookmarks toolbar. r=dao

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ed7ceca1578
Clicking on the first Address Bar result fails with the bookmarks toolbar. r=dao

Comment 20

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2ed7ceca1578

Comment 21

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ed7ceca1578

Comment 22

[Cristian Fogel [:cfogel]]

Reproduced issue with 70.0a1 (2019-08-02).
Verified fix with 70.0b8 on Windows 10.