1570751 - insecure page UI shown for no good reason

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[(no longer active)]

STR:

1. Open a new tab. Type https://www.google.com/search?q=test in the address bar and press enter.
2. After the page loads, focus the address bar and type about:about there.
3. After the second page loads, click Back.

Expected Result: the (i) Icon should change to the secure icon.

Actual Result: the (i) icon changes to the insecure icon, and then very quickly switches back to the secure icon.

Comment 1

[Johann Hofmann [:johannh]]

Yeah I've noticed this too since we introduced the insecure indicator. I'm suspecting it's something about about:blank loads but those should get the ⓘ icon technically...

I'll look into it.

Comment 2

[Cristian Fogel [:cfogel]]

In case it's still usefull, regression range:

• First bad: build_date: 2019-07-30 23:13:10.102000 changeset: e259d43073bc84dbf3aa547c3dd080d62c89f45f
• Last good: build_date: 2019-07-30 16:59:23.966000 changeset: 06cd837c3943661ed6bbeb97102807e6e5d32453
• Pushlog [URL}(https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=06cd837c3943661ed6bbeb97102807e6e5d32453&tochange=d497a1f58d27d75da3667e74a5a7efe5799119fd)

Comment 3

[Darkspirit]

mozregression --repo autoland --good 65b375326adcbd7662216779c5d9215e54f60cda --bad 1d141c74e8dc95f817048e77611eefb112872f1c -a https://example.com

3:14.57 INFO: Last good revision: c641e5c66a71a37c2c3528b6e423e90656f3a40c
3:14.57 INFO: First bad revision: 0fceabdb8b9d5fd2666e5b287b6c00cc56749610
3:14.57 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c641e5c66a71a37c2c3528b6e423e90656f3a40c&tochange=0fceabdb8b9d5fd2666e5b287b6c00cc56749610

0fceabdb8b9d5fd2666e5b287b6c00cc56749610 Johann Hofmann — Bug 1567826 - Don't mark any secureContext pages as insecure. r=nhnt11,keeler,Ehsan

Comment 5

[Johann Hofmann [:johannh]]

Attachment: Bug 1570751 - Avoid identity block flickering. r=ehsan

The security UI receives an about:blank load when navigating to or from
about: pages, which causes it to try and render security indicators before
showing the "real" security indicators for the next site. It shouldn't do that.

The solution is a bit cheap, we simply ignore all about:blank and other loads
that will receive a pageproxystate="invalid" state in the URL bar and thus
hide the identity block. This takes care of our problem and also avoids
some work when loading the home page.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/836310e3d3ee
Avoid identity block flickering. r=Ehsan

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failrues on browser_ext_popup_select.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/e208aa908846a72332c40f97768dadce6c289f61
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=259891903&repo=autoland&lineNumber=5231

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b0c2b127fcb
Avoid identity block flickering. r=Ehsan

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1b0c2b127fcb

Comment 10

[Cristian Fogel [:cfogel]]

Fix verified with 70.0a1 (2019-08-11) on Windows 10, macOS 10.13.6, Ubuntu 16.04.