1570874 - Remove unused parameters from static JobModel.retrigger() method

Status: NEW

(Tree Management :: Treeherder, enhancement, P2)

Description

[Ionuț Goldan [:igoldan]]

More details here.

Comment 1

[moijes]

Created https://github.com/mozilla/treeherder/pull/5317 for this. Will be happy to work on this. New to node as such, but will learn :).

Comment 2

[moijes]

Attachment: GitHub Pull Request

Comment 3

[Alexandru Irimovici]

I see that right now we don't use the repoName in retrigger, but I think we should use it.

When getDecisionTaskMap from PushModel is called, if there is repoName sent, it will default to autoland from what I tried locally.

I have a PR opened to be able to retrigger from compare view, where I use the repoName we send to retrigger.

https://github.com/mozilla/treeherder/pull/5304/files#diff-087f6469a8515d26800e700c0361bf46L96
https://github.com/mozilla/treeherder/pull/5304/files#diff-85a2495d1e3dcb178ea6c647320a84f5L159

@Cameron: Am I missing something or we really don't need repoName?

Comment 4

[Cameron Dawson [:camd]]

I added some review comments explaining what is happening and a good way to proceed. Please let me know if this sounds like a good approach for you. :)

Comment 5

[Alexandru Irimovici]

Sounds good to me, thanks for the review :)

Comment 6

[Shivansh Srivastava]

[:camd] I would like to work on this PR