15709 - [PP] GetFolder: Path returned is missing "/" at the end

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Jimmy Lee]

Build: 10/6/99 SeaMonkey build

1. From http://jimbob/trigger2.html, trigger
   http://jimbob/jars/a_fileop_dircreate.xpi

Install.StartInstall("Acceptance: a_fileop_dircreate", "acceptance", "1.1.1.1",
0);
f = Install.GetFolder("Program");
Install.LogComment("GetFolder returns = " + f);
Install.LogComment("Directory to create = " + f + "a_fileop_dircreate");
err = Install.DirCreate(f + "a_fileop_dircreate");
Install.LogComment("DirCreate returns = " + err);

RESULT:
The wrong directory is created.  The Install.log shows the following:
---------------------------------------------------------------------------
http://jimbob/jars/a_fileop_dircreate.xpi     --     10/06/1999  13:47:37
---------------------------------------------------------------------------

     Acceptance: a_fileop_dircreate
     ------------------------------

     ** GetFolder returns = /u/jimmylee/linux60/oct_06/package
     ** Directory to create =
/u/jimmylee/linux60/oct_06/packagea_fileop_dircreate
     ** DirCreate returns = 0
     Item [1/1]	Create Folder:
/u/jimmylee/linux60/oct_06/packagea_fileop_dircreate

     Install completed successfully
     Finished Installation  10/06/1999 13:47:38

EXPECTED RESULT:
GetFolder should return the path with the "/" at the end similar to:
/u/jimmylee/linux60/oct_06/package/

Comment 1

[Cathleen]

Doug, can you help take a look at this bug?  :-)

Comment 2

[Doug Turner (:dougt)]

the real problem is people depending strings returned from GetFolder().  We
have to check to see if the node being return from GetFolder() is a directory,
and if so, insure that there is a seperator.

Take a look at the output of http://jimbob/jars/f_getfolder_paths.xpi to see
the inconsistancies of GetFolder()

Comment 3

[Doug Turner (:dougt)]

Fix checked in.

Comment 4

[Jimmy Lee]

Build 1999-10-22-08-M11(LINUX)

Yessssssss!

Comment 5

[Sean Su]

*** Bug 15285 has been marked as a duplicate of this bug. ***

Comment 6

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine