Closed
Bug 1570925
Opened 6 years ago
Closed 6 years ago
Footer icons in the protections panel don't adapt to dark mode
Categories
(Firefox :: Site Identity, defect, P1)
Firefox
Site Identity
Tracking
()
VERIFIED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | unaffected |
| firefox70 | --- | verified |
People
(Reporter: johannh, Assigned: johannh)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [privacy-panel][skyline])
Attachments
(2 files)
Those should use context-fill. Also, while looking at this, I think the spec got rid of the context-fill-opacity for icons in the protections panel, which would make it consistent with the app menu. I'll also fix that :)
|
Assignee | |
Updated•6 years ago
|
Summary: Footer icon in the protections panel don't adapt to dark mode → Footer icons in the protections panel don't adapt to dark mode
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D40398
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/021da35e06e8
Don't use context-fill-opacity for icons in the protections panel. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/fd0e5fb0dbae
Use context-fill for footer icons in the protections panel.r=nhnt11,timhuang
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/021da35e06e8
https://hg.mozilla.org/mozilla-central/rev/fd0e5fb0dbae
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
|
||
Updated•5 years ago
|
status-firefox68:
--- → unaffected
status-firefox69:
--- → unaffected
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → unaffected
|
||
Updated•5 years ago
|
Flags: qe-verify+
|
||
Comment 5•5 years ago
|
||
I have reproduced this issue using Firefox 71.0a1 (2019.08.02) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 70.0b9 Win 10 x64, Ubuntu 18.04 x64 and macOS 10.13.6.
Flags: qe-verify+
|
|
||
Updated•5 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•