1570974 - History mouse shorcut issue

Status: NEW

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[mellogangster94]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

Browsing through history stack by holding Alt and using the mouse wheel.

Actual results:

Browsing works fine, but after releasing Alt key, the menu appears at the top, and then I need to press Alt again for it to disappear.

Expected results:

Menu shouldn't show up when using Alt key to go through history. Alt key should take mouse wheel movement into acount before showing the top menu.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a29052590fc6538b89641e690d11731ca8e78120&tochange=a04860cd9c8895aaaadaa32efec5e8b2cdcd24e8

Triggered by:
63b547bb4078856412876ffa40117a669ab20fde Masayuki Nakano — Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier r=smaug

The bug appears after Bug 143038. alt+mouse wheel triggeres back/forward navigation by default.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 3

[Qwerty]

For me this bug makes alt-shortcut unusable and I reverted history action to be shift-shortcut (as suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=1633887#c1).
Alt+scroll down/up shortcuts should work like other Alt-shortcuts (Alt+arrows, Alt+D, Alt+Home), without showing menu.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, sorry, I missed to catch cced email.

I have no idea why the bug fix caused this bug though, wheel events during Alt key press should consume Alt keyup on menubar's event listener.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Resetting assignee which I don't work on in this several months.