1571042 - "Differential Revision: " lines in commit summary/message contain two slashes (//) between host and differential ID after using |moz-phab patch|

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

moz-phab 1.32, but also before.

After moz-phab patch D<number> --apply-to . has been called, the commit messages contain a line likes this:
Differential Revision: https://phabricator.services.mozilla.com//D40435
Notice the double slash between host and differential id.

The .arcconfig looks like this:

{
  "phabricator.uri" : "https://phabricator.services.mozilla.com/",
  "repository.callsign": "MOZILLACENTRAL",
  "history.immutable": false
}

Some parts of the code assume phabricator.uri (in moz-phab references as phab-url) to not end with a slash, some do.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1571042 - Always use phabricator host without trailing slash. r=zalun

Comment 2

[Piotr Zalewa [:zalun]]

@aryx Thanks for the patch. Do you want to fix the test?