Closed Bug 1555267 Opened 5 years ago Closed 5 years ago

Use `differential.creatediff` API for submitting diffs

Categories

(Conduit :: moz-phab, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zalun, Assigned: zalun)

References

Details

(Keywords: conduit-triaged)

Attachments

(2 files)

We've tried the differential.createrawdiff and it is not working well with Phabricator.
Upstream answered [1] that it's not planned to have a right solution for other clients.
Arcanist is using the differential.creatediff, but it's undocumented.

There are 2 other clients already using the creatediff API - phlay [2] and the Kwan's fork of Mercurial's phabsend [3].

[1] Phacility answer: https://admin.phacility.com/PHI1281
[2] phlay: https://github.com/mystor/phlay
[3] forked phabsend: https://bitbucket.org/KwanEsq/phabsend-moz/src/default/

Type: defect → task
Keywords: conduit-triaged
Priority: -- → P2
Attachment #9073376 - Attachment description: Bug 1555267 - WIP submitting without arc → Bug 1555267 - Submitting a revision using the Phabricator API
Attachment #9073376 - Attachment description: Bug 1555267 - Submitting a revision using the Phabricator API → Bug 1555267 - Submitting a revision using the Phabricator API r=glob
Assignee: nobody → pzalewa
Attachment #9093621 - Attachment description: Bug 1555267 - WIP Mercurial no-arc → Bug 1555267 - WIP Mercurial no-arc r=glob
Attachment #9093621 - Attachment description: Bug 1555267 - WIP Mercurial no-arc r=glob → Bug 1555267 - Mercurial --no-arc r=glob
Depends on: 1591015
Regressions: 1597264
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: