1571181 - Mozmill, Mochitest and Marionette tests obliterated on 2019-08-03 - Thunderbird doesn't even start

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect, P1)

Description

[Jorg K (CEST = GMT+2)]

This is bad and leaves us without test coverage:
Mozmill:
jsbridge.network.JSBridgeDisconnectError: Connection timed out
Mochitest:
Automation Error: Received unexpected exception while running application
Marionette:
Process killed after 120s because no connection to Marionette server could be established. Check gecko.log for errors

This is from the last merge:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c0b4e42898753dfb4537cb39d03125e7a3&tochange=37229cef2cc79d44470afc9e04016bac8d

Funny thing is: Before going to bed, I looked at that range and thought: Nothing bad in here. How wrong was I ;-(

Comment 1

[Jorg K (CEST = GMT+2)]

Time to disable Dailies as per bug 1568758 comment #1.

Comment 2

[Jorg K (CEST = GMT+2)]

Hold on, I saw something:
1564815662130 Marionette FATAL XML Parsing Error: undefined entity
Location: chrome://messenger/content/messenger.xul
Line Number 1909, Column 9: <toolbarbutton id="appmenu_charsetMenu"
--------^

So it's this:
1f622156e9eab1d2c58d5d77bb5908fcc83db253 Zibi Braniecki — Bug 1501886 - Migrate menubar to Fluent. r=fluent-reviewers,Pike,flod

Comment 3

[Jorg K (CEST = GMT+2)]

Richard, any idea what to do here? Maybe you can join me on IRC.

Comment 4

[Jorg K (CEST = GMT+2)]

Looks like we need to do this:
https://hg.mozilla.org/mozilla-central/rev/1f622156e9eab1d2c58d5d77bb5908fcc83db253#l2.320

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1571181-appmenu_charsetMenu-fluent.patch

WIP.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1571181-appmenu_charsetMenu-fluent.patch

WIP 2, needed to remove label and accesskey.

Comment 7

[Jorg K (CEST = GMT+2)]

<menu id="charsetMenu" ... also need fixing.

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1571181-appmenu_charsetMenu-fluent.patch

This works. Main window and compose windows open again.

Not fixing:
https://searchfox.org/comm-central/rev/94e9d6789f2008114b9befe8c123e13033b05952/editor/ui/composer/content/editor.xul#169
since that is the SM mode switch in the HTML editor between Normal, All Tags and HTML views.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/607e7af11607
Port bug 1501886: add Fluent data to charsetMenu. rs=bustage-fix

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1570882-menubar.ftl.patch

The windows open but the charset menuitems are empty. Thanks to Fluent, missing strings don't break completely windows.

With this patch I hope to spot every place we have the charset menu.

Comment 11

[Richard Marti (:Paenglab)]

Comment on attachment 9082822 [details] [diff] [review]
1571181-appmenu_charsetMenu-fluent.patch

r+ to fix the bustage. But it needs some more work to show the to browser moved string.

Comment 12

[Jorg K (CEST = GMT+2)]

My push fixed most the bustage, looks like we have a failure in mozmill/composition/test-reply-multipart-charset.js, most likely due to the stuff I missed. I'll take a look now.

Comment 13

[Jorg K (CEST = GMT+2)]

Comment on attachment 9082823 [details] [diff] [review]
1570882-menubar.ftl.patch

Perfect, the Swiss save the day :-) - Thanks, Richard!!

I knew I forgotten something, like those `<html:link rel="localization" ...` lines. The test passes now. I watched it running, it exercises the app menu and picks an encoding. With an empty menu, that won't work.

Comment 14

[Jorg K (CEST = GMT+2)]

Hmm, you tried to trick me with the bug number in the patch, but I caught it. It's not bug 1570882.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/edddeb68da57
Add our own menubar.ftl for the charset menuitem. r=jorgk DONTBUILD