1571355 - Base Profiler mutex tweaks

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Some Base Profiler mutex&lock tweaks:

• Renamed BPAutoLock to BaseProfilerAutoLock.
• DEBUG-build ~BaseProfilerMutex() checks that it is unlocked.
• Prevent BaseProfilerMutex and BaseProfilerAutoLock copies&moves.
• DEBUG-build check that Lock() sees mOwningThreadId==0 (because that is the initial value, and the value after a previous Unlock()).
• Don't preserve atomic mOwningThreadId in JS recording.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1571355 - Base Profiler mutex tweaks - r?gregtatum

Renamed BPAutoLock to BaseProfilerAutoLock.
DEBUG-build ~BaseProfilerMutex() checks that it is unlocked.
Prevent BaseProfilerMutex and BaseProfilerAutoLock copies&moves.
DEBUG-build check that Lock() sees mOwningThreadId==0 (because that is the
initial value, and the value after a previous Unlock()).
Don't preserve atomic mOwningThreadId in JS recording.

Depends on D40619

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d15aca364d3d
Base Profiler mutex tweaks - r=gregtatum

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d15aca364d3d