1571450 - Snippet CTA and dismiss buttons are not visibly focused when using keyboard navigation

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: no user feedback when the user focuses a snippet button via keyboard navigation.gif

[Affected versions]:

• Firefox Nightly 70.0a1, Build ID 20190805095413

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have the browser.newtabpage.activity-stream.asrouter.devtoolsEnabled pref set to true.

[Steps to reproduce]:

1. Start the browser with a new clean profile.
2. Open a new tab and trigger a snippet with a button.
3. Select part of the snippet's text.
4. Press Tab once and observe the behavior.

[Expected results]:

• The button is highlighted/visibly focused.

[Actual results]:

• The button is focused without any feedback for the user.

[Notes]:

• The issue is reproducible for all snippets with buttons.
• The issue is also reproducible for snippets with links, but in this case only the "x" button has no user feedback when focused.
• Attached a screen recording of the issue.

Comment 1

[Kate Hudson :k88hudson]

Setting this to p2 since this is an existing issue, not a regression caused by the new feature

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5243

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/cf52300e04c9

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (70.0a1 Build ID - 20190816094815) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now the snippet's elements can be accessed through keyboard navigation.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Emily, this seems edge-case enough that we can let the fix ride Fx70 to release? Otherwise, if you think we should uplift to Beta for Fx69, please attach a patch for uplift and nominate for approval as soon as possible. Thursday's Beta is the last one before 69 goes to RC.

Comment 6

[Emily McMinn :emcminn]

Hi Ryan, let's not worry about uplifting this one - it's a pretty minor issue and waiting till Fx70 should be fine. Thanks!