1569300 - (monitor-snippet-69) [meta] Special Monitor Snippet

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5244

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1569300 - Special Monitor Snippet

Includes 5 activity-stream commits:
5118b78c Bug 1569597 - Updated schema & template, added test snippet with corr… (#5208)
5ea99ba1 Bug 1571435 - Overrode the .active class for snippets with buttons, to prevent a double highlight. (#5224)
70b63230 Bug 1571441 - Fixed snippet width and block button position on smaller screens (#5227)
9e70a342 Bug 1570026 - Part 1. Add Monitor action for snippets
46821636 Bug 1572463 - Fixes for the Special Monitor Snippet (#5235)

Comment 3

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: We'll use this bug to uplift the "monitor snippets" feature for relationships kpi

Comment 4

[Ed Lee :Mardak]

Comment on attachment 9085275 [details]
Bug 1569300 - Special Monitor Snippet

Includes 5 bugs: https://bugzilla.mozilla.org/buglist.cgi?bug_id=1569597%2C1571435%2C1571441%2C1570026%2C1572463

Beta/Release Uplift Approval Request

• User impact if declined: Not realizing if they've been part of a data breach Monitor knows about
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See QA scope: https://docs.google.com/document/d/195aSpZ-oE6Dspv4JR1CkZW9QzTvF5rw-Tz0fbjhj_zQ/edit#heading=h.fwc5z5t7r484
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The showing of this special snippet on new tab page is controlled remotely. This patch contains 5 commits including the initial implementation and followup fixes.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=14716908fbd4e495721baa756636aa74b613e443

• String changes made/needed: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9085275 [details]
Bug 1569300 - Special Monitor Snippet

Work in support of the approved relationship scoping projects targeting Fx69. Approved for 69.0b14.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/194b831613666fa13fb024c934197ee3e776e368

Comment 7

[Andrei Oprea [:andreio]]

QA tested with the following targeting expression for the 48hrs window

(currentDate|date - profileAgeCreated|date) > 48 * 3600 * 1000

Comment 8

[Ciprian Muresan [:cmuresan], Ecosystem QA, in PTO until the 4th of Dec ni? mcoman or poiegas]

Removing the qeverify flag as the feature has been signed off as YELLOW.