1571451 - The Lockwise data is not restored after restarting the browser with focus on a different tab

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: restore data.gif

[Affected Versions]:

• Nightly 70.0a1 (Build ID: 20190805095413)

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have at least one saved login.

[Steps to reproduce]:

1. Open the latest Nightly browser with the profile from prerequisites.
2. Navigate to "about:logins" page.
3. Open a website in a new tab.
4. Restart the browser (Ctrl+Shift+J then Ctrl+Alt+R keys).
5. Wait until all tabs are loaded.
6. Focus the "about:logins" page and observe the behavior.

[Expected results]:

• The sidebar displays all the saved logins and the details of the first login from the list are shown on the right side.

[Actual results]:

• The sidebar doesn't display any login and an example of login details is shown on the right side.

[Notes]:

• The saved logins are restored if the page is refreshed.
• Attached a screen recording with the issue.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1571451 - Make about:logins work when restoring with different tab focused. r=MattN

Comment 2

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7cda9f9b87859c9dba23da58db5baa818813504

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49ea02fa159c
Make about:logins work when restoring with different tab focused. r=MattN

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/49ea02fa159c

Comment 5

[Carmen Fat [:cfat] - Ecosystem QA]

• I have re-tested this scenario using the latest Nightly build (2019-08-14) on Windows 10 x64 and macOS 10.14 and the issue is still reproducible. The logins are not displayed after switching the focus from another tab to the Lockwise page.
• Given that the issue is still reproducible, I'm reopening the bug report.

Comment 6

[Matthew N. [:MattN]]

This improved some cases so we'll track the additional code in a new bug (bug 1573924).

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Based on comment bug 1573924 comment 7 the issue is fixed and no longer reproducible. Considering this I will also mark this issue as verified-fixed.