Closed Bug 1571505 Opened 3 months ago Closed 3 months ago

Implement/Enable PHC on Win64 Nightly builds for TB (port bug 1569862 and bug 1569864)

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: jorgk, Assigned: glandium)

Details

Attachments

(1 file)

TB Windows x64 builds are busted. I have no idea what this is about, I can't see anything in the M-C changesets
https://hg.mozilla.org/mozilla-central/rev/e5cfc9f74d17
https://hg.mozilla.org/mozilla-central/rev/535d865fb1a4
we could port.

Flags: needinfo?(rob)

I forgot the NIs here. Both Nicholas and Mike should come online while I sleep.

Flags: needinfo?(n.nethercote)
Flags: needinfo?(mh+mozilla)

Missing an OS_LIB somehow. It works in Firefox kind of by accident.

Assignee: nobody → mh+mozilla
Flags: needinfo?(n.nethercote)
Flags: needinfo?(mh+mozilla)

While here, properly export StackWalk.h when building with
--enable-project=memory.

Thanks, Mike. Meanwhile Rob suggested to add ac_add_options --disable-phc to the mail/config/mozconfigs/win64/nightly.

I'll try that locally and then land it as a temporary fix.

Flags: needinfo?(rob)

(In reply to Mike Hommey [:glandium] from comment #3)

Created attachment 9083177 [details]
Bug 1571505 - Properly add dbghelp where needed.

While here, properly export StackWalk.h when building with
--enable-project=memory.

My local build works with this patch, thanks.

Keywords: leave-open
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b78af834827a
disable PHC on win64 for now. rs=jorgk
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/510ac3551fb0
disable PHC on win64 for now, take 2. r=me
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/28eda64f9a93
Properly add dbghelp where needed. r=nalexander
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2675f6137221
Backed out changeset 510ac3551fb0 to re-enable PHC on win64. a=backout

You backed out take 2 but not take 1?

Flags: needinfo?(jorgk)

Wow, what a mess up. Thanks! I'll fix it now.

Flags: needinfo?(jorgk)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/79d57af23f2e
Backed out changeset b78af834827a to re-enable PHC on win64, take 2 a=backout
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Keywords: leave-open
Target Milestone: --- → Thunderbird 70.0
You need to log in before you can comment on or make changes to this bug.