1571505 - Implement/Enable PHC on Win64 Nightly builds for TB (port bug 1569862 and bug 1569864)

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Jorg K (CEST = GMT+2)]

TB Windows x64 builds are busted. I have no idea what this is about, I can't see anything in the M-C changesets
https://hg.mozilla.org/mozilla-central/rev/e5cfc9f74d17
https://hg.mozilla.org/mozilla-central/rev/535d865fb1a4
we could port.

Comment 1

[Jorg K (CEST = GMT+2)]

I forgot the NIs here. Both Nicholas and Mike should come online while I sleep.

Comment 2

[Mike Hommey [:glandium]]

Missing an OS_LIB somehow. It works in Firefox kind of by accident.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1571505 - Properly add dbghelp where needed.

While here, properly export StackWalk.h when building with
--enable-project=memory.

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks, Mike. Meanwhile Rob suggested to add ac_add_options --disable-phc to the mail/config/mozconfigs/win64/nightly.

I'll try that locally and then land it as a temporary fix.

Comment 5

[Richard Marti (:Paenglab)]

(In reply to Mike Hommey [:glandium] from comment #3)

Created attachment 9083177 [details]
Bug 1571505 - Properly add dbghelp where needed.

While here, properly export StackWalk.h when building with
--enable-project=memory.

My local build works with this patch, thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b78af834827a
disable PHC on win64 for now. rs=jorgk

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/510ac3551fb0
disable PHC on win64 for now, take 2. r=me

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28eda64f9a93
Properly add dbghelp where needed. r=nalexander

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/28eda64f9a93

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2675f6137221
Backed out changeset 510ac3551fb0 to re-enable PHC on win64. a=backout

Comment 11

[Geoff Lankow (:darktrojan)]

You backed out take 2 but not take 1?

Comment 12

[Jorg K (CEST = GMT+2)]

Wow, what a mess up. Thanks! I'll fix it now.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/79d57af23f2e
Backed out changeset b78af834827a to re-enable PHC on win64, take 2 a=backout