1571591 - regression: Cutting whole address from quantumbar now shows suggestions

Status: RESOLVED DUPLICATE of bug 1627858

(Firefox :: Address Bar, defect, P5)

Description

[Asif Youssuff]

Reported on reddit: https://www.reddit.com/r/firefox/comments/cme46e/recent_firefox_update_changed_the_beahviour_of/

Steps to reproduce:

1. Enabled quantumbar
2. Go to any website
3. Do ctrl+l, ctrl+x

What happens:

Quantumbar shows suggestions for sites to visit.

Expected result:

As previous; if I cut an address from the addressbar, I should not get suggestions as I have typed nothing to get suggestions for.

21:30.83 INFO: Last good revision: ea8eead18821aa93cdf822056e4643c7e5e58c2f
21:30.84 INFO: First bad revision: 5052e690160474c2fab0f3f238bac54f5bb2d263
21:30.84 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ea8eead18821aa93cdf822056e4643c7e5e58c2f&tochange=5052e690160474c2fab0f3f238bac54f5bb2d263

Comment 1

[Drew Willcoxon :adw]

This still happens -- at least the view stays open after you cut or delete all the text. I'm tempted to mark it invalid since we now show top sites when the urlbar is focused, and this feels similar to that. But I guess we could have a special case where we hide the view after cutting or deleting all text.

Comment 2

[Drew Willcoxon :adw]

Oops, I forgot about the pref we now have for disabling top sites. When I disable them, I can't reproduce this. I'll mark this as a dupe of bug 1627858 -- thanks for the see-also, Asif.