1571670 - The “Dismiss” button from the Extended triplets does not have a hover effect with the Default theme enabled

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P3)

Description

[Andreea Cupsa [:acupsa], Experiments QA]

Attachment: Dimiss button hover effect.gif

[Affected versions]:

• Firefox Nightly 70.0a1, Build ID: 20190804214813

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Steps to reproduce]:

1. Open the browser and open a new tab.
2. Hover the “Dismiss” button from the Extended triplets.
3. Observe the button's behavior.

[Expected result]:

• The “Dismiss” button has a hover effect.

[Actual result]:

• The “Dismiss” button does not have a hover effect.

[Notes]:

• The “Dismiss” button does have a hover effect when the Dark theme is enabled.
• This issue is also reproducible on the about:welcome page.
• Attached a screen recording of the issue:

Comment 1

[Kate Hudson :k88hudson]

This is the existing behaviour as of 67+ i.e. not a regression from previous versions, although it might be worth considering as an improvement, so I am setting this to p3.

Comment 2

[Emily McMinn :emcminn]

Attachment: Bug 1571670 - Added :hover effect to the dismiss buttons for Onboarding triplets & welcome modal

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f9b74f66da3
Added :hover effect to the dismiss buttons for Onboarding triplets & welcome modal r=k88hudson

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6f9b74f66da3

Comment 5

[Valentina Virlics [:vvalentina], Ecosystem QA]

I have verified that the issue is no longer reproducible on Firefox Nightly 74.0a1 Build ID 20200210213347 on Windows 10, Mac 10.14 and Linux Ubuntu 16.04.
The "Dismiss" button from the extended triplets has hover effect for all 3 Firefox default themes.