1569303 - (extended-triplets-69) [meta] Extended First Run Triplets

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Kate Hudson :k88hudson]

We would like to show First-Run Triplets on the new tab for a longer period of time beyond just the initial launch of the browser. The scope of this work is to extend the time they are shown, without any other major changes in design or functionality.

Some new telemetry will need to be collected in order for us to track how users engage with these extended triplets, as well as some frequency cap information and blocking functionality.

Comment 1

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: We'll use this bug to uplift the "extended triplets" feature for relationships kpi

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5252

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1569303 - Extended First Run Triplets

Includes 10 activity-stream commits:
fe05904e Bug 1560065 - Refactor first run to separate Interrupts and Triplets
cdd41d99 Bug 1560065 - Converted hooks to class component due to failing tests
d40f56fd Bug 1568909 - Show triplets for extended period after first run
82187f91 Bug 1570026 - Part 2. Refactor FirstRun to use generic fetchFlowParams
2fa2908c Bug 1571817 - Hold back rollout test for Extended Triplets (#5233)
469c7ee7 Bug 1572378 - Unable to install extension from RTAMO overlay (#5234)
00243975 Bug 1570754 - Add delay to clearing triplets and always block extended
0e377da0 Port 1570481 - Update and reorder set of first run cards r=Mardak
7af1293f Bug 1571442 - Search box shouldn't move down with extended Triplets on
d9e0fa13 Bug 1573209 - Installing addon from ReturntoAMO shouldnt hide triplets (#5248)

Comment 4

[Ed Lee :Mardak]

Comment on attachment 9085335 [details]
Bug 1569303 - Extended First Run Triplets

Includes 9 bugs: https://bugzilla.mozilla.org/buglist.cgi?bug_id=1560065%2C1568909%2C1570026%2C1571817%2C1572378%2C1570754%2C1570481%2C1571442%2C1573209

Beta/Release Uplift Approval Request

• User impact if declined: Could easily skip over the one-time triplets cards from about:welcome instead of seeing them a bit more on new tabs
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See QA scope: https://docs.google.com/document/d/16ZKPpOaPs3FLmTNePPNeNBjutCPRZrGeScDQMtWPYSA/edit#heading=h.fwc5z5t7r484

Set app.normandy.user_id to a string pref value 99 to test "holdback" experiment (i.e., no triplets on new tabs).

• List of other uplifts needed: bug 1567601 and bug 1569300
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch for uplift is on top of both bug 1567601 and bug 1569300 that touch some shared code. The behavior changes are relatively straightforward of additionally showing the about:welcome cards on new tabs although the patch is somewhat large as it includes refactoring to show the triplets on more than just about:welcome. Given the startup nature of showing about:welcome or about:home early, experimentation is built in like how it was done for Trailhead 67 dot release.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=47323c8cff2315013e1dcd373d067670c4536583

• String changes made/needed: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9085335 [details]
Bug 1569303 - Extended First Run Triplets

Work in support of the approved relationship scoping projects targeting Fx69. Approved for 69.0b14.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c2aa1c31c07e4427bea5ec58432f8806dbe4d973

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Removing the qe-verify flag as the feature has been signed off as GREEN.