1571704 - Make ThreadActor.frames return Frame fronts instead of JSON objects

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P1)

Description

[Alexandre Poirot [:ochameau]]

ThreadActor.frames is currently untyped and return JSON blobs:
https://searchfox.org/mozilla-central/rev/e62c920f7f6463239c6634113f8a8351e263b936/devtools/shared/specs/thread.js#74-79
https://searchfox.org/mozilla-central/rev/e62c920f7f6463239c6634113f8a8351e263b936/devtools/shared/fronts/thread.js#212-224

We should type correctly the frames request so that ThreadFront.getFrames return a list of FrameFront. This will then help retrieve the contextual ThreadFront/WebConsoleFront out of this FrameFront. You will be able to do: frameFront.target.getFront("thread") or frameFront.target.getFront("console"). It will help any panel having a reference to a frame to retrieve its related context.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Alex, since the change is in 'shared' dir, should this be rather in the DevTools :: Framework component?

Honza

Comment 2

[Alexandre Poirot [:ochameau]]

The Thread Actor is something specific to the debugger, so I think it is sorted correctly.

Comment 3

[Jason Laster [:jlast]]

Attachment: Bug 1571704 - Make ThreadActor.frames return Frame fronts instead of JSON objects. r=nchevobbe

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dd0214c5129
Make ThreadActor.frames return Frame fronts instead of JSON objects. r=nchevobbe

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67fb1551cc81
Backed out changeset 5dd0214c5129 for ESlint failure and causing hunks failed when backout Bug 1592616 on a CLOSED TREE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25e20d00d43f
Make ThreadActor.frames return Frame fronts instead of JSON objects. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c4bcee0f733a
Fixed eslint. CLOSED TREE

Comment 7

[Daniel Varga [:dvarga]]

Backed out 2 changesets (Bug 1571704) for xpcshell failure at devtools/server/tests/unit/test_blackboxing-01.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=c4bcee0f733ae5fb8b6f0e662fe796fbaa15ed89

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274945083&repo=autoland&lineNumber=4403

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=274944721&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=03608d5c6b84f3e8d31b6c21989a8a64f947ef71

[task 2019-11-06T23:04:05.088Z] 23:04:05     INFO -  TEST-START | devtools/server/tests/unit/test_blackboxing-01.js
[task 2019-11-06T23:09:05.147Z] 23:09:05  WARNING -  TEST-UNEXPECTED-TIMEOUT | devtools/server/tests/unit/test_blackboxing-01.js | Test timed out
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  TEST-INFO took 300056ms
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  >>>>>>>
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  (xpcshell/head.js) | test pending (2)
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  running event loop
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  PID 3847 | JavaScript strict warning: resource://devtools/shared/client/debugger-client.js, line 593: ReferenceError: reference to undefined property "type"
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  PID 3847 | DBG-TEST: resource://devtools/shared/client/debugger-client.js:593: strict error: ReferenceError: reference to undefined property "type"
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  PID 3847 | DBG-TEST: head_dbg.js observed a console message: ReferenceError: reference to undefined property "type"
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "type"" {file: "resource://devtools/shared/client/debugger-client.js" line: 593}]"
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  PID 3847 | JavaScript strict warning: resource://devtools/shared/protocol/lazy-pool.js, line 102: ReferenceError: reference to undefined property "actorID"
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  PID 3847 | DBG-TEST: resource://devtools/shared/protocol/lazy-pool.js:102: strict error: ReferenceError: reference to undefined property "actorID"
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  PID 3847 | DBG-TEST: head_dbg.js observed a console message: ReferenceError: reference to undefined property "actorID"
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "actorID"" {file: "resource://devtools/shared/protocol/lazy-pool.js" line: 102}]"
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  TEST-PASS | devtools/server/tests/unit/test_blackboxing-01.js | attachTestThread - [attachTestThread : 380] Thread client is paused - "paused" == "paused"
[task 2019-11-06T23:09:05.147Z] 23:09:05     INFO -  TEST-PASS | devtools/server/tests/unit/test_blackboxing-01.js | attachTestThread - [attachTestThread : 381] true == true
[task 2019-11-06T23:09:05.148Z] 23:09:05     INFO -  TEST-PASS | devtools/server/tests/unit/test_blackboxing-01.js | attachTestThread - [attachTestThread : 382] "attached" == "attached"
[task 2019-11-06T23:09:05.148Z] 23:09:05     INFO -  PID 3847 | Waiting for pause.
[task 2019-11-06T23:09:05.148Z] 23:09:05     INFO -  (xpcshell/head.js) | test evalCode pending (2)
[task 2019-11-06T23:09:05.148Z] 23:09:05     INFO -  PID 3847 | JavaScript strict warning: resource://devtools/server/actors/thread.js, line 231: ReferenceError: reference to undefined property "skipBreakpoints"
[task 2019-11-06T23:09:05.148Z] 23:09:05     INFO -  PID 3847 | JavaScript strict warning: resource://devtools/server/actors/utils/breakpoint-actor-map.js, line 56: ReferenceError: reference to undefined property "http://example.com/source.js:undefined:9:0"
[task 2019-11-06T23:09:05.148Z] 23:09:05     INFO -  PID 3847 | DBG-TEST: resource://devtools/server/actors/thread.js:231: strict error: ReferenceError: reference to undefined property "skipBreakpoints"
[task 2019-11-06T23:09:05.148Z] 23:09:05     INFO -  PID 3847 | DBG-TEST: head_dbg.js observed a console message: ReferenceError: reference to undefined property "skipBreakpoints"
[task 2019-11-06T23:09:05.149Z] 23:09:05     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "skipBreakpoints"" {file: "resource://devtools/server/actors/thread.js" line: 231}]"
[task 2019-11-06T23:09:05.149Z] 23:09:05     INFO -  PID 3847 | DBG-TEST: resource://devtools/server/actors/utils/breakpoint-actor-map.js:56: strict error: ReferenceError: reference to undefined property "http://example.com/source.js:undefined:9:0"
[task 2019-11-06T23:09:05.149Z] 23:09:05     INFO -  PID 3847 | DBG-TEST: head_dbg.js observed a console message: ReferenceError: reference to undefined property "http://example.com/source.js:undefined:9:0"
[task 2019-11-06T23:09:05.149Z] 23:09:05     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "http://example.com/source.js:undefined:9:0"" {file: "resource://devtools/server/actors/utils/breakpoint-actor-map.js" line: 56}]"
[task 2019-11-06T23:09:05.149Z] 23:09:05     INFO -  PID 3847 | JavaScript strict warning: resource://devtools/server/actors/thread.js, line 1374: ReferenceError: reference to undefined property "http://example.com/blackboxme.js"
[task 2019-11-06T23:09:05.149Z] 23:09:05     INFO -  PID 3847 | DBG-TEST: resource://devtools/server/actors/thread.js:1374: strict error: ReferenceError: reference to undefined property "http://example.com/blackboxme.js"
[task 2019-11-06T23:09:05.149Z] 23:09:05     INFO -  PID 3847 | DBG-TEST: head_dbg.js observed a console message: ReferenceError: reference to undefined property "http://example.com/blackboxme.js"
[task 2019-11-06T23:09:05.150Z] 23:09:05     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "http://example.com/blackboxme.js"" {file: "resource://devtools/server/actors/thread.js" line: 1374}]"
[task 2019-11-06T23:09:05.150Z] 23:09:05     INFO -  PID 3847 | Setting breakpoint.
[task 2019-11-06T23:09:05.150Z] 23:09:05     INFO -  PID 3847 | Resuming thread.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ad9bbe188ef
Make ThreadActor.frames return Frame fronts instead of JSON objects. r=nchevobbe

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7ad9bbe188ef