Closed Bug 1592616 Opened 1 year ago Closed 1 year ago

Don't show breakage report link when we're not blocking anything

Categories

(Firefox :: Protections UI, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: johannh, Assigned: johannh)

Details

Attachments

(3 files)

We're dropping these requests on the back soon, so we should not give users the illusion that their reporting has an effect when nothing is blocked.

Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fe8f0955483
Don't show breakage report link when we're not blocking anything. r=nhnt11
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c753c25b8f77
Don't show breakage report link when we're not blocking anything. r=nhnt11
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a9b6b44f82af
Don't show breakage report link when we're not blocking anything. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/7065a97d62f2
Ensure we wait for site not working link to be updated before checking visibility. r=timhuang
Attachment #9106713 - Attachment description: Bug 1592616 - Ensure we wait for site not working link to be updated before checking visibility. r=ewright,timhuang → Bug 1592616 - Ensure we wait for site not working link to be updated before checking visibility. r=timhuang
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e86703d8db17
Don't show breakage report link when we're not blocking anything. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/1f665fb32bff
Ensure we wait for site not working link to be updated before checking visibility. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/ee2ba98f5a17
Tracking milestones: set the update interval to 0 before testing the section in the panel. r=johannh

Got backed out again. 👆

This time I made sure to go through all the usages of the site not working link in tests and make sure they're up to date:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c019208de7e7d617608fb242b3b9aac2a4804b9

Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6ded6886d2ed
Don't show breakage report link when we're not blocking anything. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/7f420cfdf282
Ensure we wait for site not working link to be updated before checking visibility. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/7bc4ba491fc6
Tracking milestones: set the update interval to 0 before testing the section in the panel. r=johannh

Backed out 5 changesets (bug 1582751, bug 1575785, bug 1592616) for browser-chrome failures at browser/base/content/test/siteProtections/browser_protections_UI.js

Backout: https://hg.mozilla.org/integration/autoland/rev/5991f81dbc957f46c1ffe2d359140c96764a2086

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7bc4ba491fc60727fe154310b4a2dad0a5a0852d

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274904445&repo=autoland&lineNumber=4201

task 2019-11-06T20:20:04.569Z] 20:20:04 INFO - TEST-START | browser/base/content/test/siteProtections/browser_protections_UI.js
[task 2019-11-06T20:20:04.672Z] 20:20:04 INFO - GECKO(2555) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpFDHUNi.mozrunner/runtests_leaks_tab_pid2718.log
[task 2019-11-06T20:20:04.708Z] 20:20:04 INFO - GECKO(2555) | [Child 2718, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 729
[task 2019-11-06T20:20:04.966Z] 20:20:04 INFO - GECKO(2555) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-11-06T20:20:05.102Z] 20:20:05 INFO - GECKO(2555) | [Child 2630, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1386
[task 2019-11-06T20:20:05.103Z] 20:20:05 INFO - GECKO(2555) | [Child 2630, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1386
[task 2019-11-06T20:20:05.212Z] 20:20:05 INFO - GECKO(2555) | [Child 2718, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/workspace/build/src/dom/ipc/ContentChild.cpp, line 1789
[task 2019-11-06T20:20:05.228Z] 20:20:05 INFO - GECKO(2555) | ++DOCSHELL 0x7ff7828b6000 == 1 [pid = 2718] [id = {87e1b51e-783d-464e-a8af-17f0adb5ddbc}]
[task 2019-11-06T20:20:05.263Z] 20:20:05 INFO - GECKO(2555) | ++DOMWINDOW == 1 (0x7ff78389af20) [pid = 2718] [serial = 1] [outer = (nil)]
[task 2019-11-06T20:20:05.264Z] 20:20:05 INFO - GECKO(2555) | ++DOMWINDOW == 2 (0x7ff782873c00) [pid = 2718] [serial = 2] [outer = 0x7ff78389af20]
[task 2019-11-06T20:20:05.453Z] 20:20:05 INFO - GECKO(2555) | ++DOMWINDOW == 3 (0x7ff78380b000) [pid = 2718] [serial = 3] [outer = 0x7ff78389af20]
[task 2019-11-06T20:20:05.682Z] 20:20:05 INFO - GECKO(2555) | ++DOCSHELL 0x7ff783846000 == 2 [pid = 2718] [id = {457513fd-ccf4-499c-bfac-daa2c9ce8e11}]
[task 2019-11-06T20:20:05.683Z] 20:20:05 INFO - GECKO(2555) | ++DOMWINDOW == 4 (0x7ff78389b100) [pid = 2718] [serial = 4] [outer = (nil)]
[task 2019-11-06T20:20:05.799Z] 20:20:05 INFO - GECKO(2555) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpFDHUNi.mozrunner/runtests_leaks_tab_pid2744.log
[task 2019-11-06T20:20:05.827Z] 20:20:05 INFO - GECKO(2555) | [Child 2744, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 729
[task 2019-11-06T20:20:05.863Z] 20:20:05 INFO - GECKO(2555) | [Child 2718, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannelChild, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannelChild.cpp, line 44
[task 2019-11-06T20:20:05.863Z] 20:20:05 INFO - GECKO(2555) | [Child 2718, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannelChild, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannelChild.cpp, line 44
[task 2019-11-06T20:20:05.863Z] 20:20:05 INFO - GECKO(2555) | [Child 2718, Main Thread] WARNING: NS_ENSURE_TRUE(request) failed: file /builds/worker/workspace/build/src/netwerk/base/nsLoadGroup.cpp, line 575
[task 2019-11-06T20:20:05.886Z] 20:20:05 INFO - GECKO(2555) | [Child 2718, Main Thread] WARNING: NS_ENSURE_TRUE(currentInner) failed: file /builds/worker/workspace/build/src/dom/base/WindowDestroyedEvent.cpp, line 106
[task 2019-11-06T20:20:05.947Z] 20:20:05 INFO - GECKO(2555) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-11-06T20:20:06.051Z] 20:20:06 INFO - GECKO(2555) | [Child 2744, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/workspace/build/src/dom/ipc/ContentChild.cpp, line 1789
[task 2019-11-06T20:20:06.055Z] 20:20:06 INFO - GECKO(2555) | ++DOCSHELL 0x7fa9889b9000 == 1 [pid = 2744] [id = {457513fd-ccf4-499c-bfac-daa2c9ce8e11}]
[task 2019-11-06T20:20:06.096Z] 20:20:06 INFO - GECKO(2555) | ++DOMWINDOW == 1 (0x7fa989736f20) [pid = 2744] [serial = 1] [outer = (nil)]
[task 2019-11-06T20:20:06.098Z] 20:20:06 INFO - GECKO(2555) | ++DOMWINDOW == 2 (0x7fa988967c00) [pid = 2744] [serial = 2] [outer = 0x7fa989736f20]
[task 2019-11-06T20:20:06.396Z] 20:20:06 INFO - GECKO(2555) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpFDHUNi.mozrunner/runtests_leaks_tab_pid2764.log
[task 2019-11-06T20:20:06.412Z] 20:20:06 INFO - GECKO(2555) | [Child 2764, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 729
[task 2019-11-06T20:20:06.504Z] 20:20:06 INFO - GECKO(2555) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-11-06T20:20:06.641Z] 20:20:06 INFO - GECKO(2555) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-11-06T20:20:06.641Z] 20:20:06 INFO - GECKO(2555) | [Child 2764, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/workspace/build/src/dom/media/CubebUtils.cpp, line 381
[task 2019-11-06T20:20:06.656Z] 20:20:06 INFO - GECKO(2555) | [Child 2764, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/workspace/build/src/dom/ipc/ContentChild.cpp, line 1789
[task 2019-11-06T20:20:09.509Z] 20:20:09 INFO - GECKO(2555) | --DOCSHELL 0x7f90d68b3800 == 1 [pid = 2630] [id = {8bc76db9-b5b6-4744-9620-b09ef57fc031}] [url = about:blank]
[task 2019-11-06T20:20:09.786Z] 20:20:09 INFO - GECKO(2555) | --DOCSHELL 0x7f86534c0800 == 3 [pid = 2608] [id = {4d1a52e1-f1bd-41d0-978e-5c11e615ced5}] [url = moz-extension://431ff028-f22d-474a-9d02-9c4567482882/_generated_background_page.html]
[task 2019-11-06T20:20:11.448Z] 20:20:11 INFO - TEST-INFO | started process screentopng
[task 2019-11-06T20:20:12.111Z] 20:20:12 INFO - TEST-INFO | screentopng: exit 0
[task 2019-11-06T20:20:12.111Z] 20:20:12 INFO - Buffered messages logged at 20:20:04
[task 2019-11-06T20:20:12.111Z] 20:20:12 INFO - Entering test bound setup
[task 2019-11-06T20:20:12.112Z] 20:20:12 INFO - Leaving test bound setup
[task 2019-11-06T20:20:12.112Z] 20:20:12 INFO - Entering test bound testToggleSwitch
[task 2019-11-06T20:20:12.112Z] 20:20:12 INFO - Buffered messages logged at 20:20:06
[task 2019-11-06T20:20:12.112Z] 20:20:12 INFO - Console message: [JavaScript Warning: "The resource at “http://trackertest.org/” was blocked because content blocking is enabled." {file: "about:blank" line: 0}]
[task 2019-11-06T20:20:12.112Z] 20:20:12 INFO - Buffered messages finished
[task 2019-11-06T20:20:12.113Z] 20:20:12 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - undefined - timed out after 50 tries.
[task 2019-11-06T20:20:12.113Z] 20:20:12 INFO - Leaving test bound testToggleSwitch
[task 2019-11-06T20:20:12.113Z] 20:20:12 INFO - Entering test bound testSettingsButton

Flags: needinfo?(jhofmann)

Ugh, this is happening because the patch changes the protections_UI test to use the TRACKING_PAGE, and content blocking events don't work on fission. We need to disable this test on fission for now.

Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f5e719fbed2c
Don't show breakage report link when we're not blocking anything. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/c77f6edcaafe
Ensure we wait for site not working link to be updated before checking visibility. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/332322eb5db6
Tracking milestones: set the update interval to 0 before testing the section in the panel. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Thank you again, Nihanth!

Flags: needinfo?(jhofmann)
You need to log in before you can comment on or make changes to this bug.