Closed Bug 1571711 Opened 1 year ago Closed 5 months ago

Factorize the CrashReporterHost machinery out of the various process types

Categories

(Toolkit :: Crash Reporting, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Every different IPC process parent object in Gecko has to duplicate the machinery used to create the CrashReporterHost object and use it to get minidumps. This is obviously error-prone besides being verbose so it would be nice to factor that code out into a class that the processes' parent objects can just inherit from and use.

Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
See Also: → 1573675
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c60ee628dd0e
Factorize crash handling out of the various process IPC classes r=froydnj

Backed out changeset c60ee628dd0e (Bug 1571711) for RemoteSandboxBroker related bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=f48c581ece1bfd0f54d206d9f7d3bdf17789eded&tochange=7710c9d9b6b0b2f8f51b0d3d4e9dea3753201b25&selectedJob=261674060

Backout link: https://hg.mozilla.org/integration/autoland/rev/7710c9d9b6b0b2f8f51b0d3d4e9dea3753201b25

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261674060&repo=autoland&lineNumber=14700

[task 2019-08-14T22:38:15.902Z] 22:38:15 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/security/sandbox/win/src/remotesandboxbroker'
[task 2019-08-14T22:38:15.902Z] 22:38:15 INFO - z:/build/build/src/sccache/sccache.exe z:/build/build/src/clang/bin/clang.exe --driver-mode=cl -m32 -FoRemoteSandboxBrokerParent.obj -c -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DDEBUG=1 -DUNICODE -D_UNICODE -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/security/sandbox/win/src/remotesandboxbroker -Iz:/build/build/src/obj-firefox/security/sandbox/win/src/remotesandboxbroker -Iz:/build/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/build/build/src/ipc/chromium/src -Iz:/build/build/src/ipc/glue -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -guard:cf -Qunused-arguments -fcrash-diagnostics-dir=z:/build/public/build -TP -nologo -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -guard:cf -W3 -Gy -Zc:inline -arch:SSE2 -Gw -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang z:/build/build/src/obj-firefox/build/clang-plugin/clang-plugin.dll -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Xclang -MP -Xclang -dependency-file -Xclang .deps/RemoteSandboxBrokerParent.obj.pp -Xclang -MT -Xclang RemoteSandboxBrokerParent.obj z:/build/build/src/security/sandbox/win/src/remotesandboxbroker/RemoteSandboxBrokerParent.cpp
[task 2019-08-14T22:38:15.902Z] 22:38:15 INFO - In file included from z:/build/build/src/security/sandbox/win/src/remotesandboxbroker/RemoteSandboxBrokerParent.cpp:7:
[task 2019-08-14T22:38:15.902Z] 22:38:15 INFO - z:/build/build/src/security/sandbox/win/src/remotesandboxbroker/RemoteSandboxBrokerParent.h(18,14): error: no template named 'CrashReporterHelper'; did you mean 'ipc::CrashReporterHelper'?
[task 2019-08-14T22:38:15.902Z] 22:38:15 INFO - public CrashReporterHelper<GeckoProcessType_RemoteSandboxBroker> {
[task 2019-08-14T22:38:15.903Z] 22:38:15 INFO - ^~~~~~~~~~~~~~~~~~~
[task 2019-08-14T22:38:15.903Z] 22:38:15 INFO - ipc::CrashReporterHelper
[task 2019-08-14T22:38:15.903Z] 22:38:15 INFO - z:/build/build/src/obj-firefox/dist/include\mozilla/ipc/CrashReporterHelper.h(32,7): note: 'ipc::CrashReporterHelper' declared here
[task 2019-08-14T22:38:15.903Z] 22:38:15 INFO - class CrashReporterHelper {
[task 2019-08-14T22:38:15.903Z] 22:38:15 INFO - ^
[task 2019-08-14T22:38:15.904Z] 22:38:15 INFO - 1 error generated.
[task 2019-08-14T22:38:15.904Z] 22:38:15 INFO - z:/build/build/src/config/rules.mk:785: recipe for target 'RemoteSandboxBrokerParent.obj' failed
[task 2019-08-14T22:38:15.904Z] 22:38:15 INFO - mozmake.EXE[4]: *** [RemoteSandboxBrokerParent.obj] Error 1
[task 2019-08-14T22:38:15.904Z] 22:38:15 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/security/sandbox/win/src/remotesandboxbroker'
[task 2019-08-14T22:38:15.904Z] 22:38:15 INFO - mozmake.EXE[4]: *** Waiting for unfinished jobs....
[task 2019-08-14T22:38:16.206Z] 22:38:16 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/media/libvpx'
[task 2019-08-14T22:38:16.206Z] 22:38:16 INFO - media/libvpx/vp9_svc_layercontext.obj
[task 2019-08-14T22:38:16.206Z] 22:38:16 INFO - z:/build/build/src/sccache/sccache.exe z:/build/build/src/clang/bin/clang.exe --driver-mode=cl -Xclang -std=gnu99 -m32 -Fovp9_svc_layercontext.obj -c -DDEBUG=1 -DHAVE_CONFIG_H=vpx_config.h -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/media/libvpx -Iz:/build/build/src/obj-firefox/media/libvpx -Iz:/build/build/src/media/libvpx/config/win/ia32 -Iz:/build/build/src/media/libvpx/config -Iz:/build/build/src/media/libvpx/libvpx -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -guard:cf -fcrash-diagnostics-dir=z:/build/public/build -nologo -D_HAS_EXCEPTIONS=0 -guard:cf -W3 -Gy -Zc:inline -arch:SSE2 -Gw -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Z7 -Xclang -load -Xclang z:/build/build/src/obj-firefox/build/clang-plugin/clang-plugin.dll -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Qunused-arguments -Wno-sign-compare -Wno-unused-function -Wno-unreachable-code -Wno-unneeded-internal-declaration -Xclang -MP -Xclang -dependency-file -Xclang .deps/vp9_svc_layercontext.obj.pp -Xclang -MT -Xclang vp9_svc_layercontext.obj z:/build/build/src/media/libvpx/libvpx/vp9/encoder/vp9_svc_layercontext.c
[task 2019-08-14T22:38:16.206Z] 22:38:16 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/media/libvpx'

Flags: needinfo?(gsvelto)

Ugh, I had fixed the problem locally on my machine and I must have forgotten to arc diff --update before landing. Sorry for the noise.

Flags: needinfo?(gsvelto)
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/69224eff4d07
Factorize crash handling out of the various process IPC classes r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.