1571846 - `update_action` message does not set preference value after reset

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Andrei Oprea [:andreio]]

We found some issues with the update_action message handling that could make the WNP fail to show up.
https://github.com/mozilla/activity-stream/pull/5223

Comment 1

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a28a338396c3

Comment 2

[Ed Lee :Mardak]

Could you provide QA steps for this? I believe the user facing bug is that a lower priority Moment message doesn't correctly get replaced by a higher priority message?

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/feeaf170fca669a675eff2cb16bd56b0a329b508

Comment 4

[Andrei Oprea [:andreio]]

On a fresh profile:

1. Set browser.newtabpage.activity-stream.asrouter.providers.panel_local_testing to {"id":"panel_local_testing", "cohort": "SHOW_TEST"}
2. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
3. Trigger WNP_THANK_YOU from asrouter admin

Expected:

1. browser.startup.homepage_override.once is set
2. After 5 minutes pref value is still set

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

Tested using the mentioned steps. Please note that for the local trigger, it works as expected. Verified as fixed using Fx70.0a1 and Fx69.0b15 on windows 10 x64, ubuntu 18.04 and macOS 10.13 The message is still displayed after 5 minutes.

Please note that if a server message overrides the local WNP message, after 5 minutes the pref for 'browser.startup.homepage_override.once' is lost. This would not be desirable as per discussions, the server received message has a higher priority and will always override the local WNP message. Can you confirm if this is intended?

Comment 6

[Andrei Oprea [:andreio]]

I can't reproduce any issues.