1571934 - Inline security-prefs.js into all.js

Status: RESOLVED FIXED

(Core :: Security, task)

Description

[Nicholas Nethercote [inactive]]

I'm not aware of any reason for them to be separate.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1571934 - Inline security-prefs.js into all.js. r=keeler

security-prefs.js is #included into greprefs.js, but there's no good reason for
it to be separate from all.js. Having it separate makes it easier to overlook,
and all.js has a bunch of security.* prefs in it anyway.

This patch inlines it into all.js. It inlines it at the start of the file to
minimize the risk of the change, so that the prefs end up in greprefs.js in the
same order as before.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1571934 - Remove redundant security.tls.enable_0rtt_data definition. r=keeler

It's defined first as false, and again later in the file as true. This patch
removes the first definition, which is currently overridden by the second.

Depends on D40919

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a84c1c3fd62
Inline security-prefs.js into all.js. r=keeler
https://hg.mozilla.org/integration/autoland/rev/7f90ee314512
Remove redundant security.tls.enable_0rtt_data definition. r=mbirghan

Comment 4

[Nicholas Nethercote [inactive]]

jorgk: the security-prefs.js entry in suite/installer/removed-files.in might need removing in comm-central.

Comment 5

[Jorg K (CEST = GMT+2)]

Thanks, Nicholas. suite/ is for SeaMonkey, so I'll forward this.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0a84c1c3fd62
https://hg.mozilla.org/mozilla-central/rev/7f90ee314512

Comment 7

[Frank-Rainer Grahl (:frg)]

Nicolas,

thanks. The reference in comm-central/suite is harmless. Unly used during uninstall and optional. I plan to clean this file up anyway and will then remove it.