Closed Bug 1571934 Opened 4 months ago Closed 4 months ago

Inline security-prefs.js into all.js

Categories

(Core :: Security, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(2 files)

I'm not aware of any reason for them to be separate.

security-prefs.js is #included into greprefs.js, but there's no good reason for
it to be separate from all.js. Having it separate makes it easier to overlook,
and all.js has a bunch of security.* prefs in it anyway.

This patch inlines it into all.js. It inlines it at the start of the file to
minimize the risk of the change, so that the prefs end up in greprefs.js in the
same order as before.

It's defined first as false, and again later in the file as true. This patch
removes the first definition, which is currently overridden by the second.

Depends on D40919

Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a84c1c3fd62
Inline security-prefs.js into all.js. r=keeler
https://hg.mozilla.org/integration/autoland/rev/7f90ee314512
Remove redundant security.tls.enable_0rtt_data definition. r=mbirghan

jorgk: the security-prefs.js entry in suite/installer/removed-files.in might need removing in comm-central.

Flags: needinfo?(jorgk)
Blocks: 1572331

Thanks, Nicholas. suite/ is for SeaMonkey, so I'll forward this.

Flags: needinfo?(jorgk) → needinfo?(frgrahl)
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Assignee: nobody → n.nethercote

Nicolas,

thanks. The reference in comm-central/suite is harmless. Unly used during uninstall and optional. I plan to clean this file up anyway and will then remove it.

Flags: needinfo?(frgrahl)
You need to log in before you can comment on or make changes to this bug.