1572109 - The focus remains blocked on the "Create New Login" button when using the "Tab" key to navigate if the "Edit/Create" mode is opened

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: focus remains blocked on the Create New Login button.gif

[Affected Versions]:

• Nightly 70.0a1

[Affected Platforms]

• All Windows
• All Mac
• All Linux

[Prerequisites]

• Have a Firefox profile with at least one saved login.

[Steps to reproduce]:

1. Open the latest Nightly browser with the profile from prerequisites.
2. Navigate to "about:logins" page and select a saved login.
3. Click the "Edit" button.
4. Press the "Tab" key until the "Create New Login" button is focused.
5. Press again the "Tab" key and observe the behavior.

[Expected results]:

• The next element from the page gets focused.

[Actual results]:

• The focus remains blocked on the "Create New Login" button.

[Notes]:

• The issue is also reproducible when the "Create New Login" mode is opened.
• Attached a screen recording with the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

The bug here is in the code that manually advances focus to the Edit button from the login-list. Since the Edit button is hidden in edit mode, focus doesn't move.

Comment 2

[Lesley Norton [:lnorton]]

Attachment: Bug 1572109: Fix tabbing in edit mode. r=jaws

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffa35308113f
Fix tabbing in edit mode. r=jaws

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ffa35308113f

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift to beta? Thanks.

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64.

• The issue is not longer reproducible when you are in "Edit" mode. All the buttons can be focused using the "Tab" key.
• But, it seems that the issue is still reproducible when the "Create New Login" mode is opened. I have logged a new issue for this in bug 1579818.

Considering this, I will mark this issue as verified fixed and will track the issue from "Create New Login" mode bug 1579818.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Does this need Beta uplift?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Yes, it needs uplift. I am working with David Durst and MattN to coordinate a single uplift of multiple patches to make sure they land in order and are merged properly.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e0bea141177c

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the Firefox Beta 70.0b8 (Build ID:20190919164641) build on Windows 10 x64, Mac 10.14 and Ubuntu 18.04 x64.

The issue is not longer reproducible when you are in "Edit" mode. All the buttons can be focused using the "Tab" key.