1576175 - [about:logins] Tab key doesn't select anything from the warning panel

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Oana Botisan, Desktop QA]

Attachment: Peek 2019-08-23 16-36.gif

Affected versions

• Firefox 70.a01

Affected platforms

• Windows 10 x64
• Ubuntu 18.04 x64
• macOS 10.13

Prerequisites

• Have at least one breached site saved in the profile-- instructions on how to do this can be found here

Steps to reproduce

1. Go to "about:logins".
2. Press the "Tab" key until the "Learn more about this breach" hyperlink inside the warning banner is focused.

Expected result

• The hyperlink is in focus.

Actual result

• The hyperlink never gets in focus.

Regression range

• I don't think this is a regression.

Additional notes

• The same thing happens for the "X" (close) button.
• The "X" (close) is in focus only if the user click on the warning banner, but the "Learn more about this breach" hyperlink still doesn't get in focus.
• The only time the "Learn more about this breach" hyperlink gets in focus is when you click on the text inside the warning banner.

Comment 1

[Tim Nguyen :ntim]

You can tab backwards to the alert, so I think this is somewhat the same issue as bug 1572109 with the JS forcing the focus from the list to the edit button.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1576175 - Move focus handling to login-item and forward focus to the breach alert when it is visible during tabbing. r?MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e64bc498809
Move focus handling to login-item and forward focus to the breach alert when it is visible during tabbing. r=MattN

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7e64bc498809

Comment 5

[Oana Botisan, Desktop QA]

We verified the fix using lastest Nightly 71.0a1 on Ubuntu 18.04 x64, Windows 10 x64 and macOS 10.14. The issue is not reproducing anymore.

Comment 6

[Marco Zehe (:MarcoZ)]

Hi jaws, could this be uplifted to beta?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9b189b93fb77

Comment 8

[Oana Botisan, Desktop QA]

I verified the fix using Firefox 70.0b9 on Windows 10 x64, Ubuntu 18 x64 and macOS 10.13. The issue is not reproducing anymore.