Closed Bug 1572211 Opened 3 months ago Closed 3 months ago

Do not rely on AxisHeight for the layout of mfrac elements without bar

Categories

(Core :: MathML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: fredw, Assigned: fredw)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

AxisHeight is not involved in the layout:
https://mathml-refresh.github.io/mathml-core/#fraction-with-zero-line-thickness

Confirmed by Microsoft:
https://lists.w3.org/Archives/Public/public-mathml4/2019Aug/0019.html

See https://github.com/mathml-refresh/mathml/issues/123

frac-parameters-2.html was changed to use nonzero AxisHeight to test gap parameters in
https://github.com/web-platform-tests/wpt/pull/18299
and that exhibited the Firefox bug.

Unneeded test for AxisHeight is removed in
https://github.com/web-platform-tests/wpt/pull/18323

Attached patch PatchSplinter Review

@Emilio: I'm not familiar with the new patch format / review process. But Here is a patch that fixes the bug in the code.

Test results should be updated once they are synchronized again with WPT.

I can push that to try and see if there are other tests to update.

Flags: needinfo?(emilio)
See Also: → 1572213, 1571852
Flags: needinfo?(emilio)
Keywords: checkin-needed

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5d589b74745
Do not rely on AxisHeight for the layout of mfrac elements without bar. r=emilio
https://hg.mozilla.org/integration/autoland/rev/48fa8b517d7b
Update test expectation for layout of mfrac elements without bar. r=emilio

Keywords: checkin-needed

These are duplicate and out-of-date version of the following web platform tests:

testing/web-platform/tests/mathml/presentation-markup/fractions/frac-parameters-1.html
testing/web-platform/tests/mathml/presentation-markup/fractions/frac-parameters-2.html
testing/web-platform/tests/mathml/relations/css-styling/lengths-2.html

The failing mochitest was a duplicate and out-of-date copy of frac-parameters-2.html

Flags: needinfo?(fred.wang)
Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa4c230df929
Do not rely on AxisHeight for the layout of mfrac elements without bar. r=emilio
https://hg.mozilla.org/integration/autoland/rev/25b77061eb1a
Update test expectation for layout of mfrac elements without bar. r=emilio

Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d9b0975e6e71
Remove MathML imported mochitests. r=emilio
You need to log in before you can comment on or make changes to this bug.