1572211 - Do not rely on AxisHeight for the layout of mfrac elements without bar

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang (:fredw)]

AxisHeight is not involved in the layout:
https://mathml-refresh.github.io/mathml-core/#fraction-with-zero-line-thickness

Confirmed by Microsoft:
https://lists.w3.org/Archives/Public/public-mathml4/2019Aug/0019.html

See https://github.com/mathml-refresh/mathml/issues/123

frac-parameters-2.html was changed to use nonzero AxisHeight to test gap parameters in
https://github.com/web-platform-tests/wpt/pull/18299
and that exhibited the Firefox bug.

Unneeded test for AxisHeight is removed in
https://github.com/web-platform-tests/wpt/pull/18323

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Patch

@Emilio: I'm not familiar with the new patch format / review process. But Here is a patch that fixes the bug in the code.

Test results should be updated once they are synchronized again with WPT.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I can push that to try and see if there are other tests to update.

Comment 3

[Frédéric Wang (:fredw)]

Attachment: Bug 1572211 - Do not rely on AxisHeight for the layout of mfrac elements without bar. r=emilio

AxisHeight is not involved in the layout of <mfrac> with zero linethickness:
https://mathml-refresh.github.io/mathml-core/#fraction-with-zero-line-thickness

Confirmed by Microsoft:
https://lists.w3.org/Archives/Public/public-mathml4/2019Aug/0019.html

See https://github.com/mathml-refresh/mathml/issues/123

Comment 4

[Frédéric Wang (:fredw)]

Attachment: Bug 1572211 - Update test expectation for layout of mfrac elements without bar. r=emilio

Depends on D41189

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5d589b74745
Do not rely on AxisHeight for the layout of mfrac elements without bar. r=emilio
https://hg.mozilla.org/integration/autoland/rev/48fa8b517d7b
Update test expectation for layout of mfrac elements without bar. r=emilio

Comment 6

[Oana Pop-Rus]

Backed out 2 changesets (bug 1572211) for mochitests failures on test_stack-parameters.html

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=261348499&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-e10s-13%2Cm%2813%29&revision=48fa8b517d7bbcf1fd49d0c06fde59ca6b694817

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261348499&repo=autoland&lineNumber=14617

Backout: https://hg.mozilla.org/integration/autoland/rev/54853be004185a34289361d6bfb8b9cf45b52128

Comment 7

[Frédéric Wang (:fredw)]

Attachment: Bug 1572211 - Remove MathML imported mochitests. r=emilio

These are duplicate and out-of-date version of the following web platform tests:

testing/web-platform/tests/mathml/presentation-markup/fractions/frac-parameters-1.html
testing/web-platform/tests/mathml/presentation-markup/fractions/frac-parameters-2.html
testing/web-platform/tests/mathml/relations/css-styling/lengths-2.html

Comment 8

[Frédéric Wang (:fredw)]

The failing mochitest was a duplicate and out-of-date copy of frac-parameters-2.html

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa4c230df929
Do not rely on AxisHeight for the layout of mfrac elements without bar. r=emilio
https://hg.mozilla.org/integration/autoland/rev/25b77061eb1a
Update test expectation for layout of mfrac elements without bar. r=emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9b0975e6e71
Remove MathML imported mochitests. r=emilio

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/aa4c230df929
https://hg.mozilla.org/mozilla-central/rev/25b77061eb1a
https://hg.mozilla.org/mozilla-central/rev/d9b0975e6e71